Last modified: 2014-03-01 00:14:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50051, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48051 - VisualEditor: Newly-created list items are deliberately not merged with nearby lists - change this?
VisualEditor: Newly-created list items are deliberately not merged with nearb...
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal enhancement
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-03 16:36 UTC by Dan Barrett
Modified: 2014-03-01 00:14 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dan Barrett 2013-05-03 16:36:17 UTC
In Firefox 20.0.1:

1. Edit a page that has a bulleted list.
2. Place the cursor on the first bullet item.
3. Click the "Bullet List" button. The first bullet item loses its bullet. (Correct.)
4. Click the "Bullet List" button a second time. The first bullet comes back (correct), but there is now a blank line displayed below it.

Similarly, if you remove & add a bullet in the middle of the list, you get blank lines above AND below the item.

Similarly, if you do this with a numbered list, the blank line breaks the numbering: the list items below the blank line start over from "1".
Comment 1 James Forrester 2013-05-09 19:27:53 UTC
(In reply to comment #0)
> In Firefox 20.0.1:
> 
> 1. Edit a page that has a bulleted list.
> 2. Place the cursor on the first bullet item.
> 3. Click the "Bullet List" button. The first bullet item loses its bullet.
> (Correct.)
> 4. Click the "Bullet List" button a second time. The first bullet comes back
> (correct), but there is now a blank line displayed below it.
> 
> Similarly, if you remove & add a bullet in the middle of the list, you get
> blank lines above AND below the item.
> 
> Similarly, if you do this with a numbered list, the blank line breaks the
> numbering: the list items below the blank line start over from "1".

Yes, because otherwise we'd be unexpectedly merging a <p> with a following <ul> (or whatever). You can always actively choose to merge the lists from this position by deleting the blank line between the lists (technically, this is a slug).

This is the deliberately-chosen behaviour for this. I take it you'd expect lists to instead automatically merge, and you'd have to split them rather than the other way around? X followed by X is not generally a direct reverse step (that's what undo is for), but you expected it to work that way around?
Comment 2 Dan Barrett 2013-05-09 20:11:42 UTC
Interesting point. I think nontechnical end-users will have a different perspective, however. Both Microsoft Word and Google Docs will produce a single bulleted list as the result. Your users are going to be accustomed to that behavior.

When an end-user clicks the button the first time, and the bullet disappears, they won't be thinking that "a bulleted list has become two lists." They'll simply think "a bullet symbol has been removed."
Comment 3 James Forrester 2013-05-09 21:42:01 UTC
(In reply to comment #2)
> Interesting point. I think nontechnical end-users will have a different
> perspective, however. Both Microsoft Word and Google Docs will produce a
> single bulleted list as the result. Your users are going to be accustomed to
> that behavior.

Possibly.

> When an end-user clicks the button the first time, and the bullet disappears,
> they won't be thinking that "a bulleted list has become two lists." They'll
> simply think "a bullet symbol has been removed."

Not two lists - they'll have a paragraph and a list.

I'll make sure we do some real-world tests with non-technical people to come to a decision on this.
Comment 4 Dan Barrett 2013-05-09 22:19:26 UTC
FWIW, I also just checked OpenOffice.org, and they also simply remove and restore the bullet, keeping a single bulleted list.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links