Last modified: 2007-04-02 06:28:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 4764 - My contributions is not bold when on page
My contributions is not bold when on page
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.6.x
All All
: Normal trivial with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.org/wiki/Special:...
:
: 8794 9359 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-01-26 22:15 UTC by Edward Z. Yang
Modified: 2007-04-02 06:28 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Edward Z. Yang 2006-01-26 22:15:32 UTC
Log into a Wikimedia project and click My watchlist. Note how it is bold. Now
click on My contributions.

Expected result: My contributions is bold
Actual result: My contributions is not bold

Reproducible: Always

Related link:
http://en.wikipedia.org/wiki/Wikipedia:Administrators%27_noticeboard#The_.22my_contributions.22__link
which lead me to file the bug. It's really trivial though.
Comment 1 Brion Vibber 2006-01-27 00:17:54 UTC
This seems to be explicitly disabled at the moment in SkinTemplate.php:

# FIXME #  'active' => ( $href == $pageurl . '/' . $this->username )

If just uncommented it would fail on usernames with spaces, special chars, etc,
and also on subsequent views with extra parameters because of how the target
gets passed differently.
Comment 2 Edward Z. Yang 2006-01-27 00:29:46 UTC
Use the Title object. Seems trivial to fix... something like

$contributions_title =& Title::makeTitle(NS_SPECIAL, 'Contributions/' .
$this->username);
$contributions_url = $user->escapeLocalURL();
Comment 3 Edward Z. Yang 2006-01-27 00:31:51 UTC
Above fix wouldn't fix the problem on "subsequent views with extra parameters"
though. It's a half-step towards the solution. Somehow, the skin would have to
know that: one, the current page was Special:Contributions and two, the current
page's target was the current username.
Comment 4 lɛʁi לערי ריינהארט 2006-02-19 09:38:19 UTC
(In reply to comment #3)
> ... It's a half-step towards the solution. ...

Hallo!

Maybe a "half-step towards the solution" is better then actual behaviour.
[[Special:Recentchangeslinked/Main_Page]] does not have this problem. It shoes
2468 watched items both in wiki syntax and with special parameters.

Marking as 'depends on':
Bug 2468: The code that generates the namespace form for Special:Contributions,
Special:Allpages and Special:Recentchanges should be merged

best regards reinhardt [[user:gangleri]]
Comment 5 lɛʁi לערי ריינהארט 2006-02-19 10:00:26 UTC
(In reply to comment #4)
> ... It shoes
> 2468 watched items both in wiki syntax and with special parameters.

please read
It shoes *bold* watched items both in wiki syntax and with special parameters.

Sorry wrong "copy and paste".
Comment 6 Brion Vibber 2006-02-21 03:20:56 UTC
Remove bogus dependency. Please stop spreading this crap all over the place.
Comment 7 Jason Quinn 2006-10-14 04:19:27 UTC
I first noticed this bug. It hadn't been commented on in a while. It seems like
it should be simple to fix. I also noticed that MediaWiki itself doesn't do the
whole bold highlighting thing. Shouldn't it?
Comment 8 Rob Church 2007-01-27 18:13:16 UTC
*** Bug 8794 has been marked as a duplicate of this bug. ***
Comment 9 Nick Jenkins 2007-03-21 09:45:22 UTC
*** Bug 9359 has been marked as a duplicate of this bug. ***
Comment 10 Rob Church 2007-04-02 06:28:14 UTC
Fixed in r20902.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links