Last modified: 2013-07-07 15:49:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49577, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 47577 - "test" repository in the tarball does not compile


Summary:	"test" repository in the tarball does not compile

Status:	RESOLVED DUPLICATE of bug 48106

Product:	openZIM
Classification:	Unclassified
Component:	zimlib (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal
Target Milestone:	---
Assigned To:	Tommi Mäkitalo

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-04-23 22:04 UTC by Kelson [Emmanuel Engelhart]
Modified:	2013-07-07 15:49 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Kelson [Emmanuel Engelhart] 2013-04-23 22:04:15 UTC

$ make
depbase=`echo cluster.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
	g++ -DHAVE_CONFIG_H -I. -I../src  -I../include   -g -O2 -Wno-long-long -Wall -pedantic -MT cluster.o -MD -MP -MF $depbase.Tpo -c -o cluster.o cluster.cpp &&\
	mv -f $depbase.Tpo $depbase.Po
cluster.cpp:25:37: fatal error: cxxtools/unit/testsuite.h: No such file or directory
compilation terminated.
make: *** [cluster.o] Error 1

Comment 1 Tommi Mäkitalo 2013-06-30 18:24:24 UTC

The test direcoty contains unit tests based on cxxtools. You need to have cxxtools installed to compile it.

Best way to do it is to run configure with --enable-unittest. The configure check, if cxxtools is available and complains about missing cxxtools if not.

Comment 2 Kelson [Emmanuel Engelhart] 2013-06-30 18:38:47 UTC

If the tests depend on cxxtools, wouldn't that be better to disable this feature per default?

Comment 3 Tommi Mäkitalo 2013-06-30 18:47:48 UTC

It is disabled by default. It must be explicitly enabled with --enable-unittest.

Comment 4 Kelson [Emmanuel Engelhart] 2013-07-01 07:16:57 UTC

Then, it's perfect IMO. This "bug" was reported by the Debian packager to me... so I should ask him what exactly was wrong (I can't remember) :(

Comment 5 Kelson [Emmanuel Engelhart] 2013-07-07 12:58:13 UTC

@Vasudev, are you OK with that? Should we close this ticket as INVALID?

Comment 6 Vasudeva Kamath 2013-07-07 15:43:44 UTC

Hi Kelson,

I've no problem with having extra dependency and I enable unit test while building package. The problem which I faced was due to missing linker flag. I've also given a proposed patch for that not sure if it got accepted or not

Comment 7 Vasudeva Kamath 2013-07-07 15:46:56 UTC

And here is the bug with patch which I reported https://bugzilla.wikimedia.org/show_bug.cgi?id=48106

Comment 8 Kelson [Emmanuel Engelhart] 2013-07-07 15:49:24 UTC


*** This bug has been marked as a duplicate of bug 48106 ***

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links