Last modified: 2014-01-11 23:29:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49554, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 47554 - move mediawiki/rcsub.git under mediawiki/tools
move mediawiki/rcsub.git under mediawiki/tools
Status: NEW
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
wmf-deployment
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-23 14:24 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-01-11 23:29 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2013-04-23 14:24:31 UTC
mediawiki/rcsub is a python script which I believe should be under mediawiki/tools/rcsub
Comment 1 Antoine "hashar" Musso (WMF) 2013-04-23 14:24:56 UTC
ccing vvv who is the author.
Comment 2 Chad H. 2013-04-23 14:30:38 UTC
Moving repositories is incredibly disruptive right now...is there a really good reason for this other than aesthetics?
Comment 3 Antoine "hashar" Musso (WMF) 2013-05-21 08:50:39 UTC
That is merely for consistency.  Whenever Gerrit is finally able to rename a repository, we will be able to fix that bug.  IIRC Christian is more or less working on such a feature.
Comment 4 christian 2013-05-21 20:07:44 UTC
(In reply to comment #3)
> IIRC Christian is more or less
> working on such a feature.

Yes, that's correct:
https://gerrit.wikimedia.org/r/#/q/project:gerrit+branch:wmf+topic:rename-project,n,z

And Chad said that those patches will go into the next gerrit build.
Comment 5 Aravind K N 2014-01-10 12:41:51 UTC
Could someone assign this bug for me?
Comment 6 Andre Klapper 2014-01-10 14:42:51 UTC
Christian is already working on this and this is not a good item for newcomers, sorry. :)
Comment 7 christian 2014-01-11 23:29:58 UTC
(In reply to comment #6)
> Christian is already working on this

Sadly ... Christian “used to be” working on this would better reflect
the status quo.

We had a working solution in place and updated it for some time. But
upstream was a bit reluctant to review, as the overall change (~5K LOC
spread into about a dozen changes, adding locking mechanism in inner
parts of gerrit) is huge for the meager benefit of being able to
rename projects. So it never got merged upstream. But as there are no
simpler solutions in sight directly inside gerrit, and since upstream
did not show interest, I stopped investing time.

Even when patching our gerrit to contain those changes, maintaining
them would not be fun.

@Aravind, I'll gladly discuss the current patches with you. If you've
got a love for Java, it might well be possible to do renaming in a
plugin, if you ignore all the possible race conditions. But updating
the patches that handle all the races and add the functionality
directly in gerrit is probably not worth it, as I doubt that upstream
would review it this time. Especially now, when they are more focused
on things like the new ChangeScreen.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links