Last modified: 2006-01-19 10:42:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T6665, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 4665 - diff shows article blanked, but it wasn't
diff shows article blanked, but it wasn't
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
  Show dependency treegraph
Reported: 2006-01-19 01:56 UTC by Rick Block
Modified: 2006-01-19 10:42 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Rick Block 2006-01-19 01:56:46 UTC
The diff above indicates a page blanking occurred, but the page was not blanked.  See user request at
Comment 1 Brion Vibber 2006-01-19 02:47:21 UTC
A possibility off the top of my head is a load failure from external storage caused 
by replication lag, followed by storing of the bogus diff in the diff cache.
Comment 2 Brion Vibber 2006-01-19 04:25:37 UTC
Tim poked in some fallback code which should prevent this from happening.
Resolving FIXED.
Comment 3 Tim Starling 2006-01-19 04:59:02 UTC
I've committed three changes to address this:

1. external storage checks the master if a blob is not available on the slave
2. Revision::getText() does not deserialize or inflate if the external storage
engine returned false
3. DifferenceEngine::getDiffBody() checks for errors from Revision::getText()
and handles them appropriately.

That should fix the problem one way or another.

Note You need to log in before you can comment on or make changes to this bug.