Last modified: 2006-01-19 10:42:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 4665 - diff shows article blanked, but it wasn't
diff shows article blanked, but it wasn't
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
unspecified
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.org/w/index.php?t...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-01-19 01:56 UTC by Rick Block
Modified: 2006-01-19 10:42 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Rick Block 2006-01-19 01:56:46 UTC
The diff above indicates a page blanking occurred, but the page was not blanked.  See user request at http://en.wikipedia.org/wiki/
Wikipedia:Village_pump_%28technical%29#Bug_in_diff.3F
Comment 1 Brion Vibber 2006-01-19 02:47:21 UTC
A possibility off the top of my head is a load failure from external storage caused 
by replication lag, followed by storing of the bogus diff in the diff cache.
Comment 2 Brion Vibber 2006-01-19 04:25:37 UTC
Tim poked in some fallback code which should prevent this from happening.
Resolving FIXED.
Comment 3 Tim Starling 2006-01-19 04:59:02 UTC
I've committed three changes to address this:

1. external storage checks the master if a blob is not available on the slave
2. Revision::getText() does not deserialize or inflate if the external storage
engine returned false
3. DifferenceEngine::getDiffBody() checks for errors from Revision::getText()
and handles them appropriately.

That should fix the problem one way or another.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links