Last modified: 2014-05-06 16:16:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T48634, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 46634 - Avoid breakage of conversion rules from [numeric-only string] to [something else] by replacing array_merge() calls by operator+
Avoid breakage of conversion rules from [numeric-only string] to [something e...
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
Language converter (Other open bugs)
1.22.0
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-03-28 13:10 UTC by Liangent
Modified: 2014-05-06 16:16 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Liangent 2013-03-28 13:10:28 UTC 
There're various array_merge() calls on conversion tables, and it re-indexes the array if the array is keyed with numbers. These calls can be replaced with operator+, which only performs hashtable-merge.
Comment 1 Gerrit Notification Bot 2013-06-03 04:57:54 UTC 
Related URL: https://gerrit.wikimedia.org/r/66376 (Gerrit Change Ic1fecc1526e66ed83061f2b4ad77c8ef95622216)
Comment 2 Gerrit Notification Bot 2014-05-06 16:02:58 UTC 
Change 66376 abandoned by Liangent:
Handle conversion rules of numeric-only string correctly

https://gerrit.wikimedia.org/r/66376
Comment 3 Gerrit Notification Bot 2014-05-06 16:16:44 UTC 
Change 131717 had a related patch set uploaded by Liangent:
LanguageConverter fix of empty and numeric strings

https://gerrit.wikimedia.org/r/131717
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links