Last modified: 2006-06-05 19:50:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 4663 - Toolbar should be enabled for Safari
Toolbar should be enabled for Safari
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.6.x
All All
: Normal normal with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 4921 5324 6210 (view as bug list)
Depends on: 4662
Blocks:
  Show dependency treegraph
 
Reported: 2006-01-19 01:18 UTC by Schnargel
Modified: 2006-06-05 19:50 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Schnargel 2006-01-19 01:18:50 UTC
The toolbar (above the edit window) was at some point disabled for the Safari browser by a change to skins/common/wikibits.js (probably by the 
change from Revision 1.14 to 1.15).

Current Safari versions handle the toolbar functions pretty well so it should be re-enabled for Safari.

Proposed fix:

The function addButton in wikibits.js contains:

 if (!document.selection && !is_gecko) {
  return false;
 }

The first of these lines should be replaced by

 if (!is_safari && !is_gecko) {

(Since that code is executed when a page loads, document.selection might always be undefined)
Comment 1 Brion Vibber 2006-02-08 23:38:15 UTC
*** Bug 4921 has been marked as a duplicate of this bug. ***
Comment 2 Brion Vibber 2006-03-22 21:39:16 UTC
*** Bug 5324 has been marked as a duplicate of this bug. ***
Comment 3 Peter Beentje 2006-03-24 12:07:21 UTC
Found a wiki that I could edit with buttons, and did a search for inurl:special:version for more data points: at time of writing the buttons are visible in wikis that use MediaWikis pre 
1.5.6, 1.5rc3 and rc4, but not wikis using MediaWiki 1.6alpha. Didn't find any 1.5.7s I could log into though.
Comment 4 Brion Vibber 2006-04-17 10:37:01 UTC
Fixed on trunk, r13689.
Comment 5 Brion Vibber 2006-06-05 19:50:17 UTC
*** Bug 6210 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links