Last modified: 2014-05-15 14:01:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T48361, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 46361 - handle no value and other property snak types in property parser function
handle no value and other property snak types in property parser function
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataClient (Other open bugs)
master
All All
: High normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=5
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-20 14:33 UTC by Aude
Modified: 2014-05-15 14:01 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Aude 2013-03-20 14:33:12 UTC
We need to handle no value and other property snak types in the property parser function
Comment 1 Aude 2013-03-20 15:02:48 UTC
Right now, these get skipped completely.  We want these to output as an empty string with comma or whichever separator specified.

With multiple values, it would be like:

Mary, Jack, , Joe
Comment 2 Aude 2013-03-20 18:34:47 UTC
any property parser function call that returns an error should have the same behaviour when there are multiple values.

For no value, we might want it to output (none) or something like that.
Comment 3 Marius Hoch 2014-04-22 23:08:25 UTC
(In reply to Aude from comment #2)
> [...]
> For no value, we might want it to output (none) or something like that.

Lua currently outputs <wikibase-snakview-snaktypeselector-novalue> in client... we can move that message to lib, then it will appear like: "no value" (without any brackets though), not sure that's desired.
Comment 4 Gerrit Notification Bot 2014-04-22 23:31:12 UTC
Change 129072 had a related patch set uploaded by Hoo man:
Move the messages to describe novalue and somevalue Snaks to lib

https://gerrit.wikimedia.org/r/129072
Comment 5 Gerrit Notification Bot 2014-04-23 08:29:11 UTC
Change 129072 merged by jenkins-bot:
Move the messages to describe novalue and somevalue Snaks to lib

https://gerrit.wikimedia.org/r/129072

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links