Last modified: 2010-05-15 14:36:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T6617, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 4617 - Add "assign to ___" to Tasks forms
Add "assign to ___" to Tasks forms
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Tasks (Other open bugs)
unspecified
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-01-15 03:51 UTC by Phil Harnish
Modified: 2010-05-15 14:36 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patches Tasks extension (5.64 KB, patch)
2006-01-15 03:54 UTC, Phil Harnish
Details
Apply patch to HEAD of Tasks extension, take 2 (5.28 KB, patch)
2006-01-15 04:52 UTC, Phil Harnish
Details
Apply patch to HEAD of Tasks extension, take 3 (4.78 KB, patch)
2006-01-16 16:07 UTC, Phil Harnish
Details

Description Phil Harnish 2006-01-15 03:51:49 UTC
This patch will add two new text boxes which allow a task to be assigned to a
specific username. 
The first box appears under the "Comments" field and allows a new task to be
assigned to someone.
The second box appears in the "Assignment/Actions/Page" column for a task if not
already assigned.

This required adding one additional string to en.php which contains "Assign to".
I have attempted a French translation ("Assignée Ã") using other text and what
little I remember from high school.
Comment 1 Phil Harnish 2006-01-15 03:54:47 UTC
Created attachment 1309 [details]
Patches Tasks extension

This patches the HEAD version of Tasks.php, en.php, and fr.php
Comment 2 Ævar Arnfjörð Bjarmason 2006-01-15 03:58:20 UTC
Component => Tasks
Comment 3 Phil Harnish 2006-01-15 04:52:32 UTC
Created attachment 1310 [details]
Apply patch to HEAD of Tasks extension, take 2

Changes suggested by Ævar Arnfjörð Bjarmason
- Encode ?title= value to prevent injection (real big mistake, sorry)
- Handle usernames which may be '0' or other flavors of "empty"
- Removed French translation of "Assign to"
- Removed commented line which could print "Assigned to no one"
Comment 4 Phil Harnish 2006-01-15 04:59:08 UTC
cc: magnus_manske
Comment 5 Ævar Arnfjörð Bjarmason 2006-01-16 14:11:31 UTC
Fails to apply to current CVS HEAD, also looks like you're using Windows
newlines which mess up the patch
Comment 6 Phil Harnish 2006-01-16 16:07:49 UTC
Created attachment 1314 [details]
Apply patch to HEAD of Tasks extension, take 3

Editor removed trailing whitespace so it was not able to match surrounding
text. This even happened when I tested the patch. It should work this time.
Sorry for the trouble.

Reproduced modifications from scratch (with trailing space maintained),
regenerated patch, tested patch against HEAD, tested patched file in wiki.
Comment 7 Rob Church 2006-01-17 22:15:42 UTC
Closing, since Phil says this has been committed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links