Last modified: 2006-01-12 22:12:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 4576 - "None" option doesn't display in Opera or IE
"None" option doesn't display in Opera or IE
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
PC Windows XP
: Normal major with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
http://commons.wikimedia.org/wiki/Spe...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-01-12 13:12 UTC by Andreas Vilén
Modified: 2006-01-12 22:12 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Andreas Vilén 2006-01-12 13:12:52 UTC
On the upload page for commons, there should be an option "none", in the multiple choice list. In IE or Opera (and 
possibly other browsers), the none option is not shown, because the code is misinterpreted as "<option value=''>". 
The code looks like

<option value=''>None selected</option>
<option value="Unknown" title="{{Unknown}}">I don't know what the license is</option>

It should be (I guess) option value="" instead. It works in Firefox, but not in Opera or IE, and since still most 
users use IE this should be fixed.

This is somewhat critical since users using other browsers than Firefox can't upload images with a certain licence 
tag without lying about the tag (as in choosing a random licence tag in the list) and later changing it manually.

Thank you very much in advance!
Comment 1 Ævar Arnfjörð Bjarmason 2006-01-12 21:56:17 UTC
(In reply to comment #0)
> It should be (I guess) option value="" instead. It works in Firefox, but not
in Opera or IE, and since still most 
> users use IE this should be fixed.

You guess or you've tried that and it works? Please say what exact user agent
you're using.
Comment 2 Andreas Vilén 2006-01-12 22:00:43 UTC
I guessed, didn't check. I checked now, and the code shows like

<option value=''>None selected</option>
<option value="Unknown" title="{{Unknown}}">I don't know what the license is</option>

in Firefox too... In Firefox though, I see the "none" value, which I'm sure you also do. I don't know if the 
problem is browser specific, but it should in some way be fixed so that IE and Opera users also can upload images 
properly. I don't know anything about coding myself.
Comment 3 Brion Vibber 2006-01-12 22:12:16 UTC
Close, but the problem was actually the missing '>' on the line above,
which caused the <select> to not be closed properly.

Single-quotes are perfectly ok on XML/HTML attributes.

Fixed in SpecialUpload.php revision 1.100.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links