Last modified: 2013-03-08 16:44:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47738, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 45738 - Use "owner" instead of the "last reviewer" in gerrit notifications
Use "owner" instead of the "last reviewer" in gerrit notifications
Status: RESOLVED WORKSFORME
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
wmf-deployment
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-05 13:35 UTC by Helder
Modified: 2013-03-08 16:44 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Helder 2013-03-05 13:35:22 UTC
Copying from
http://thread.gmane.org/gmane.science.linguistics.wikipedia.technical/67899
----
Can we get the "owner" instead of the "last reviewer" in the text
below, when a change is merged?

---------- Forwarded message ----------
From: jenkins-bot (Code Review) <gerrit <at> wikimedia.org>
(...)
jenkins-bot has submitted this change and it was merged.
(...)
Gerrit-Owner: SomeoneDifferentFromJenkinsBot <mail <at> mail.org>
----
Comment 1 Antoine "hashar" Musso (WMF) 2013-03-05 16:31:58 UTC
For the context, the text comes from the email notifications sent by Gerrit

Mail-from: is the account that triggered the mail notification.

Gerrit-Owner is the person in charge of the Gerrit change, which is who ever has committed the first patchset.

Gerrit-Reviewer are the accounts that looked at the change.


So if you want the "owner", look for the 'Gerrit-Owner:' field =)
Comment 2 Helder 2013-03-05 19:38:28 UTC
Isn't the owner who submited the change? Why would we say that it was submited by jenkins-bot?
Comment 3 Helder 2013-03-05 19:41:15 UTC
As far as I can see, jenkins-bot is just a code reviewer, not someone who submits code changes...
Comment 4 Antoine "hashar" Musso (WMF) 2013-03-08 16:44:13 UTC
The Jenkins bot does submit patches :-]  On mediawiki/core whenever someone send a comment with CR+2, that triggers a testing job in Jenkins that will ultimately submit the code.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links