Last modified: 2014-05-02 01:17:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 4561 - Generated user stylesheet should not set text color
Generated user stylesheet should not set text color
Status: RESOLVED WORKSFORME
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 6160 (view as bug list)
Depends on:
Blocks: css
  Show dependency treegraph
 
Reported: 2006-01-11 02:22 UTC by Schnargel
Modified: 2014-05-02 01:17 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Schnargel 2006-01-11 02:22:34 UTC
The "generated user stylesheet" (/w/index.php?title=-&action=raw&gen=css) is used to do special link formatting depending on the settings in the 
user's preferences.

Among other things it defines text color #cc2200 for a.new and (if "highlightbroken" is set) #772233 for a.stub:after which don't belong there 
because it does not know about the color scheme defined in other stylesheets. While it does not conflict with the current MediaWiki skins it is likely 
to cause problems with any (user) skins that use different background colors.

Text and background colors should always be defined in the same place.
Comment 1 Antoine "hashar" Musso (WMF) 2006-01-17 19:16:36 UTC
Please provide an example of such trouble.

I havent experienced any trouble with the dark theme 'Amethyst'.
Comment 2 Schnargel 2006-01-17 20:55:05 UTC
You would have had problems with highlightbroken turned off reading a "!" in color #772233 on the #2f333b background, and since user style 
sheets are allowed I could easily come up with a brown or red theme. 

The current solution is a quick "dirty" hack and restricts the choice of colors in skin style sheets where all these color definitions belong to. For 
the same reason (not to define a text color without the background color) the PNGs of the math and hiero extension have a white and not 
transparent background even though black on transparent would display well on the current standard skin backgrounds.

Comment 3 Rob Church 2006-01-17 23:38:53 UTC
It's a problem if our code makes assumptions that might be reasonably be
expected to be incompatible.
Comment 4 Rob Church 2006-06-15 06:38:14 UTC
*** Bug 6160 has been marked as a duplicate of this bug. ***
Comment 5 Krinkle 2011-12-30 19:17:45 UTC
To clarify, this bug requests that the alternate styling for red-links is not defined statically in PHP where this is generated, but by the skin itself.

That's a bit complicated though since it can't be made part of the main skins' stylesheet since it should only be applied if this preference is enabled.

Possible solutions:
* Let skins provide a separate css module for this module, and have a default fallback in case none is specified by the skin
* Do let it be part of the main skins' stylesheet, but instead of overwriting a.new styles, let PHP output an additional class on all a.new links for this (e.g. <a class="new highlightbroken">).
* Let it be as it is until this preference is deprecated and removed
Comment 6 Krinkle 2013-11-12 23:13:41 UTC
This preference has been removed a while back in 1.19.0.

https://github.com/wikimedia/mediawiki-core/commit/c78f613b38a2c9d87d48485f350d32007a60f68c

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links