Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47254, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 45254 - Make eval.php subclass Maintenance

Summary:	Make eval.php subclass Maintenance

Status: RESOLVED INVALID Product: MediaWiki Classification: Unclassified Component: Maintenance scripts (Other open bugs) Version: unspecified Hardware: All All Importance: Low enhancement (vote) Target Milestone: --- Assigned To: Nobody - You can work on this! URL: Whiteboard: Keywords: Depends on: Blocks: 25782   Show dependency tree / graph		Reported: 2013-02-21 22:14 UTC by Antoine "hashar" Musso (WMF) Modified: 2013-02-22 13:56 UTC (History) CC List: 1 user (show) wikibugs-l See Also: Web browser: --- Mobile Platform: --- Assignee Huggle Beta Tester: ---

Attachments Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2013-02-21 22:14:25 UTC eval.php is still using the old commandline.inc wrapper. Should be a class extending Maintenance. Comment 1 Sam Reed (reedy) 2013-02-22 00:26:07 UTC No, both Chad and I have done this separately and it's been reverted. https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=commit;h=a528b8ba92e6d949496f017f9f448dcfeb1b283d https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=commit;h=268edfd9e4673dace0d8e9dd9aab357cf3033dc3 See https://www.mediawiki.org/wiki/Special:Code/MediaWiki/﷒0﷓ Comment 2 Antoine "hashar" Musso (WMF) 2013-02-22 13:56:40 UTC For history purpose: it turns out we want eval.php to run in the global context.