Last modified: 2013-04-22 16:14:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47251, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 45251 - Encoding mismatch in gettingstarted tour


Summary:	Encoding mismatch in gettingstarted tour

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	GuidedTour (Other open bugs)
Version:	master
Hardware:	All All

Importance:	High major (vote)
Target Milestone:	---
Assigned To:	Matthew Flaschen

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-02-21 20:32 UTC by Matthew Flaschen
Modified:	2013-04-22 16:14 UTC (History)
CC List:	8 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Matthew Flaschen 2013-02-21 20:32:48 UTC

I thought the encoding of wgPageName matched wikiUrlencode.  However, that's not 100% the case, the so there are mismatches for certain cases, like those with parens.

For example, on Heissler of Heitersheim (Donat John Count):

wikiUrlencode: Heissler_of_Heitersheim_%28Donat_John_Count%29
wgPageName: Heissler_of_Heitersheim_(Donat_John_Count)

This will cause some title matches to be missed, resulting in the tour not showing.

Comment 1 Matthew Flaschen 2013-02-22 00:59:49 UTC

Ready for review: https://gerrit.wikimedia.org/r/#/c/50326/

Comment 2 Matthew Flaschen 2013-02-22 02:23:24 UTC

Reviewed and merged.

We plan to deploy this tomorrow.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links