Last modified: 2013-09-09 20:15:49 UTC
Created attachment 11752 [details] PDF print preview showing the problem I'm on Mac OS X 10.6, Safari, but I bet this problem could occur on other systems and browsers also. I was in the middle of uploading multiple images with the UploadWizard tool on Commons, and it showed the same thumbnail twice for two different files (different images). See the attached PDF print preview showing the bug. For the first file, a different thumbnail should have been displayed.
Wait - in the UploadWizard, I may have actually selected the same file twice by accident, because when I published all the uploads, the last file previewed (which 'correctly' had the same thumbnail displayed as the first file) failed to upload. The red error message said that it was a duplicate of the first file (the one with the wrong thumbnail), which was the first upload to be published. But I have uploaded the correct image for the first file, and right now I am working on uploading the last file that I attached previously to the UploadWizard (the one that failed).
Closing this as Invalid.
Hold on - I didn't select the same file twice. Look at the attached PDF screenshot. The files all have different names. But the UploadWizard, for some reason, "thought" that I had selected the same image twice. So this IS a real bug.
(In reply to comment #3) > Hold on - I didn't select the same file twice. Look at the attached PDF > screenshot. The files all have different names. But the UploadWizard, for > some > reason, "thought" that I had selected the same image twice. > > So this IS a real bug. Im going to guess this only happens some of the time. If there is any chance you could make a list of steps that would result in the bug showing up always, that would help a lot. (Assuming that is even possible)
Right, I should be able to reproduce this.
I am marking this as UNCONFIRMED due to lack of steps to reproduce and improper bug report. The bug reporter seemed confused and there's a slight chance that there was no actual error here.. If someone else comes across this please reopen and try to list some steps to reproduce this bug.
How do you define "error"? Does there have to be red text that shows up on the page? That didn't happen, but the tool DID produce the same thumbnail twice for two different files on my computer that I selected. The tool then published the same photo twice, under different file names. I don't know of any steps that would produce this problem again, and it hasn't happened again, but I do have evidence in the PDF file attached to this bug report. Does anyone know of a different bug report here or a complaint on Commons about this problem?
(In reply to comment #7) > How do you define "error"? Does there have to be red text that shows up on > the > page? Any sort of unexpected behaviour can be considered an error. Don't worry your issue meets the definition.
I can confirm this bug, and probably help narrow down the circumstances. It has happened to me several times. For me, it happens in combination with an issue in which I cannot add multiple files, though I am allowed to proceed without a warning box. I am also using Safari (version 5.1.7 on Mac OS 10.6.8). It seems to me that this browser is incapable of permitting the selection of multiple files during a single transaction in the Upload Wizard. 1. click "upload file" in Commons, invoking the wizard. 2. click "select a media file to share". 3. in the OS file selection box, select several image files using shift or command key. 4. click "choose" 5. The upload wizard will behave as though you only chose one of the files. It is the last of the files selected in step 3, but the thumbnail displayed is from the first of the files. (The file name displayed is correct.)
(In reply to comment #9) Yeah, that inability to select more than one file at once happens to me too. > I can confirm this bug, and probably help narrow down the circumstances. It > has > happened to me several times. For me, it happens in combination with an issue > in which I cannot add multiple files, though I am allowed to proceed without > a > warning box. > > I am also using Safari (version 5.1.7 on Mac OS 10.6.8). > > It seems to me that this browser is incapable of permitting the selection of > multiple files during a single transaction in the Upload Wizard. > > 1. click "upload file" in Commons, invoking the wizard. > 2. click "select a media file to share". > 3. in the OS file selection box, select several image files using shift or > command key. > 4. click "choose" > 5. The upload wizard will behave as though you only chose one of the files. > It > is the last of the files selected in step 3, but the thumbnail displayed is > from the first of the files. (The file name displayed is correct.)
Oh, another detail, perhaps useful: this process seems to bypass the Upload Wizard's ability to detect that a file is a duplicate. For instance, this upload resulted from the bug currently under discussion; but ordinarily, an upload like this would not be permitted. http://commons.wikimedia.org/wiki/File:Participants_in_the_Wikipedia_and_Legislative_Data_workshop_03.jpg
Proof that the UploadWizard uploaded the same file twice: I had to upload a new version of this image just below. http://commons.wikimedia.org/wiki/File:North_Umpqua,_Deadline_Falls.jpg (In reply to comment #0) > Created attachment 11752 [details] > PDF print preview showing the problem > > I'm on Mac OS X 10.6, Safari, but I bet this problem could occur on other > systems and browsers also. > > I was in the middle of uploading multiple images with the UploadWizard tool > on > Commons, and it showed the same thumbnail twice for two different files > (different images). > > See the attached PDF print preview showing the bug. For the first file, a > different thumbnail should have been displayed.
(In reply to comment #10) > Yeah, that inability to select more than one file at once happens to me too. This seems like another bug, but then how did you upload multiple files in the screenshot? does this happen only sometimes that you can't select more than one file?
Yes, that's another bug that only appears sometimes (and not at all for me recently). What happens is that when I click "Select media files to share" I use the "shift" key on my computer to select two or more files to upload at once, but when I click "Choose" the UploadWizard acts as if I had only chosen one file. It looks like that bug has already been reported: Bug 46845, and it looks like you just commented there. I think I got around the multiple files bug when uploading the North Umpqua photos back in February by only selecting one file at a time, since I had experienced the multiple files bug many times before.
I was able to reproduce this bug using crossbrowsertesting.com but I can't work on this without a mac. Will try pinging someone else to work on this one.
Googling shows this is a bug in Safari http://stackoverflow.com/questions/15766644/any-workarounds-for-the-safari-html5-multiple-file-upload-bug but we need to be sure
Seems limited to Safari 5.1 (Definitely windows, possibly mac too). We could add a browser check and remove(/not add) the multiple attribute from(/to) the control. Not too nice, but it would do the trick.
Related URL: https://gerrit.wikimedia.org/r/64851 (Gerrit Change Ib60dd151965310d0a567c7d888b4638cc48a696d)
So, Nischay, you think that the multiple file upload problem is related to this wrong thumbnail problem by code? (In reply to comment #16) > Googling shows this is a bug in Safari > http://stackoverflow.com/questions/15766644/any-workarounds-for-the-safari- > html5-multiple-file-upload-bug > but we need to be sure
(In reply to comment #19) I think so, but I am not sure. We can't investigate the wrong thumbnail problem until I am able to upload multiple files. I think this bug can also be reproduced in Safari/Win7, I will setup that and try investigating further.
I tried to upload multiple files but only one uploads successfully and the thumbnail is broken for that one :p <rant>Switch to a better browser<rant/>
I have abandoned the change as the workaround wasn't working well. Also closing as WONTFIX; its a problem with Safari https://github.com/blueimp/jQuery-File-Upload/issues/703
Okay, well thanks so much for taking the time to investigate this. (In reply to comment #22) > I have abandoned the change as the workaround wasn't working well. > > Also closing as WONTFIX; its a problem with Safari > https://github.com/blueimp/jQuery-File-Upload/issues/703
I've also noticed problems uploading multiple files from Safari. Should we just disable multifile upload from Safari completely?
Safari windows in that case. Always worked just fine for me.
(In reply to comment #24) > Should we just disable multifile upload from Safari completely? It's just with some particular versions so doesn't make sense to disable it completely. Is there a reliable way to detect Safari and its version? (In reply to comment #25) > Safari windows in that case. Always worked just fine for me. As I said its with some versions only AFAIK
Created attachment 13259 [details] PDF print preview showing when the problem happened again It happened again today when I was using the wizard.
The bug still exists if you use Safari, because it was decided to NOT fix it ("WONTFIX"). See comment 26.
Yes, I understand that this hasn't been fixed. I'm just reporting that it happened again for me for the first time since February. (In reply to comment #28) > The bug still exists if you use Safari, because it was decided to NOT fix it > ("WONTFIX"). See comment 26.
