Last modified: 2013-07-31 16:24:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46652, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 44652 - Improve performance of round-trip test setup
Improve performance of round-trip test setup
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
tests (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Marc Ordinas i Llopis
:
Depends on:
Blocks: 46659
  Show dependency treegraph
 
Reported: 2013-02-04 20:14 UTC by Gabriel Wicke
Modified: 2013-07-31 16:24 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gabriel Wicke 2013-02-04 20:14:51 UTC
Our current round-trip test server is bogging down with the large DB it has accumulated by now. This makes it the bottleneck in rt testing, leaving the clients mostly idle.

Much of the db size is XML-encoded old test results, which we don't really need any more. Moving those large results to a separate db might make it easier to truncate old results by simply re-creating the result xml db.

Apart from the DB size, the node.js sqlite bindings we use don't seem to help performance either. IIRC they don't support transactions and other performance-improving features / pragmas. We mainly used sqlite because it was easy to get started, but it might make sense to re-evaluate that choice. A separate DB server would at least make it possible to use two cores instead of just one.
Comment 1 Gabriel Wicke 2013-07-03 16:13:21 UTC
WIP patch: https://gerrit.wikimedia.org/r/#/c/69156/
Comment 2 Gabriel Wicke 2013-07-10 16:18:18 UTC
Another issue with the current code is that marking repeated crashing titles as failed does not work reliably. There is a counter in the claims table that should mark the title as an error on reaching some number of retries.
Comment 3 Marc Ordinas i Llopis 2013-07-16 18:08:37 UTC
(In reply to comment #2)
> Another issue with the current code is that marking repeated crashing titles
> as
> failed does not work reliably. There is a counter in the claims table that
> should mark the title as an error on reaching some number of retries.

I've proposed a patch that should fix this:
https://gerrit.wikimedia.org/r/#/c/73985/
Comment 4 Gerrit Notification Bot 2013-07-25 16:07:46 UTC
Change 75895 had a related patch set uploaded by Marcoil:
Refactor the database schema for performance. To use only the pages table to determine the next title to be processed, store the latest claim (hash, timestamp and number of tries) and latest score for each page. Then, to get the next title query for the o

https://gerrit.wikimedia.org/r/75895
Comment 5 Gerrit Notification Bot 2013-07-29 18:09:04 UTC
Change 75895 merged by jenkins-bot:
Refactor the database schema for performance.

https://gerrit.wikimedia.org/r/75895
Comment 6 Marc Ordinas i Llopis 2013-07-31 16:24:31 UTC
Fix is in rt_testing branch, reopen if more work is necessary before merging into master.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links