Last modified: 2013-04-22 16:15:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46157, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 44157 - The return value of realpath should be tested or realpath should be avoided


Summary:	The return value of realpath should be tested or realpath should be avoided

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	General/Unknown (Other open bugs)
Version:	1.21.x
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Mark A. Hershberger

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	44132
	Show dependency tree / graph

Reported:	2013-01-19 17:02 UTC by Mark A. Hershberger
Modified:	2013-04-22 16:15 UTC (History)
CC List:	2 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Mark A. Hershberger 2013-01-19 17:02:50 UTC

There are several places in the code where realpath() is used without verifying that it didn't return false despite the two cases where realpath returns false:

   realpath() returns FALSE on failure, e.g. if the file does not exist.

   The running script must have executable permissions on all
   directories in the hierarchy, otherwise realpath() will return FALSE. 

The permission bit caused bug #44132.

Comment 1 Mark A. Hershberger 2013-01-19 20:22:16 UTC

See https://gerrit.wikimedia.org/r/44832

Comment 2 Alex Monk 2013-02-03 17:40:26 UTC

Merged by Tim Starling on the 31st. Is this bug fixed now?

Comment 3 Alex Monk 2013-02-16 22:30:16 UTC

Let's assume it is then.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links