Last modified: 2006-02-20 01:26:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 4413 - Persian LanguageFa.php hardcodes project namespace as Wikipedia
Persian LanguageFa.php hardcodes project namespace as Wikipedia
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Internationalization (Other open bugs)
1.6.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks: 4036 4087 4130 4460
  Show dependency treegraph
 
Reported: 2005-12-28 23:26 UTC by Brion Vibber
Modified: 2006-02-20 01:26 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
LanguageFa.php patch for HEAD (985 bytes, patch)
2005-12-29 00:58 UTC, Zigger
Details
LanguageFa.php patch for HEAD (21.99 KB, patch)
2005-12-29 03:56 UTC, Zigger
Details
LanguageFa.php patch for HEAD (21.99 KB, patch)
2005-12-29 03:59 UTC, Zigger
Details

Description Brion Vibber 2005-12-28 23:26:07 UTC
This breaks all non-Wikipedia languages set to Persian (fa.wikibooks, fa.wikisource, etc).
Comment 1 Kaveh 2005-12-29 00:50:17 UTC
I see what the problem is now. If I were to submit a patch, what should I change
the instances of "Wikipedia" in LanguageFa.php to?
Comment 2 lɛʁi לערי ריינהארט 2005-12-29 00:57:21 UTC
Use "Project:" wherever "Wikipedia" is used.
Comment 3 lɛʁi לערי ריינהארט 2005-12-29 00:58:24 UTC
(In reply to comment #2)
> Use "Project:" wherever "Wikipedia" is used.

Use "Project:" wherever "Wikipedia:" is used. (now both are with colon ":")
Comment 4 Zigger 2005-12-29 00:58:42 UTC
Created attachment 1241 [details]
LanguageFa.php patch for HEAD
Comment 5 Kaveh 2005-12-29 01:18:14 UTC
I am looking at LanguageHe, and in some instances they've used {{ns:project}}
and in others {{SITENAME}}. What's the distintion here?
Comment 6 Zigger 2005-12-29 01:53:31 UTC
(After exchanging emails with Kaveh (thanks), I'm continuing with the patch.)

{{SITENAME}} is for display only, and "{{ns:project}}:" is better than
"Project:" as it will use the translation during rendering.
Comment 7 Zigger 2005-12-29 03:56:01 UTC
Created attachment 1243 [details]
LanguageFa.php patch for HEAD

Changes:
o Small white-space fix
o fixes the hard-coded Project namespaces
o translates the Template, Help, and Category namespaces
o uses {{ns:project}} and {{SITENAME}} instead of hard-coding
o ensures that passwordreminder messages are inherited
o improves the welcomecreation message

(Thanks to Kaveh for the translations and checking.)

Not done (& won't be done by me):
o testing
o comparisons with Special:Allmessages on fa sites
o translation/removal of messages in English
o translations of missing messages
o checking/fixing pseudo-namespaces on fa sites
Comment 8 Zigger 2005-12-29 03:59:53 UTC
Created attachment 1244 [details]
LanguageFa.php patch for HEAD

Fixed list typo.
Comment 9 JeLuF 2006-01-01 23:04:17 UTC
Fixed in CVS, LanguageFa.php, rev 1.51.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links