Last modified: 2010-05-15 15:38:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 4380 - Database.php:Avoid unsuccessful login query
Database.php:Avoid unsuccessful login query
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Installer (Other open bugs)
1.5.x
PC FreeBSD
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-12-24 19:38 UTC by Wei-Yu Chen
Modified: 2010-05-15 15:38 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Wei-Yu Chen 2005-12-24 19:38:10 UTC
Index: Database.php
===================================================================
RCS file: /cvsroot/wikipedia/phase3/includes/Database.php,v
retrieving revision 1.139
diff -u -r1.139 Database.php
--- Database.php        22 Dec 2005 06:30:39 -0000      1.139
+++ Database.php        24 Dec 2005 19:35:15 -0000
@@ -301,13 +301,13 @@

                if ( !$success ) {
                        $this->reportConnectionError();
-               }
-
-               global $wgDBmysql5;
-               if( $wgDBmysql5 ) {
-                       // Tell the server we're communicating with it in 
UTF-8.
-                       // This may engage various charset conversions.
-                       $this->query( 'SET NAMES utf8' );
+               } else {
+                       global $wgDBmysql5;
+                       if( $wgDBmysql5 ) {
+                               // Tell the server we're communicating with 
it in UTF-8.
+                               // This may engage various charset 
conversions.
+                               $this->query( 'SET NAMES utf8' );
+                       }
                }

                $this->mOpened = $success;
Comment 1 Brion Vibber 2007-01-15 22:58:52 UTC
This was fixed a while ago.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links