Last modified: 2007-02-03 22:55:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T6347, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 4347 - UserMailer: replyto problem: use the string for mailing, not the (MailAddress) object
UserMailer: replyto problem: use the string for mailing, not the (MailAddress...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.6.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2005-12-22 00:42 UTC by T. Gries
Modified: 2007-02-03 22:55 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
patch; needs review (871 bytes, patch)
2005-12-22 00:43 UTC, T. Gries 		Details
revised patch (CVS HEAD) -- please review and apply (1.04 KB, patch)
2005-12-22 20:16 UTC, T. Gries 		Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Description T. Gries 2005-12-22 00:42:07 UTC 
recently, the MailAddress object was introduced for the "to" and "from" string in UserMailer. "replyto" strings 
need to be handled in a similar way (patch follows).
Comment 1 T. Gries 2005-12-22 00:43:17 UTC 
Created attachment 1227 [details]
patch; needs review
Comment 2 T. Gries 2005-12-22 20:16:07 UTC 
Created attachment 1230 [details]
revised patch (CVS HEAD) -- please review and apply

I forgot the patch for the variable $wgNoReplyAddress --> MailAddress(
$wgNoReplyAddress ), which is used for composing the REPLY-TO when a)
pageeditor has no mailaddress, e.g. anonymous editors. or b) pageeditor has
opted-out to reveal their address or c) the feature is fully switched off by
Sysop.

Paging the devlopers to commit this after review.
Comment 3 T. Gries 2005-12-23 17:29:53 UTC 
Brion, hello.

Please can you fix that problem now ? You apparently forgot to patch these three
lines when you recently introduced MailAddress() objects in UserMailer.php.

As you know, I cannot commit to the CVS.
Comment 4 T. Gries 2006-01-01 11:09:12 UTC 
need-review, patch
Comment 5 Antoine "hashar" Musso (WMF) 2007-02-03 22:55:26 UTC 
I corrected some typo and committed it as r19746.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links