Last modified: 2013-07-04 10:33:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T45236, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 43236 - Citation references are zero-indexed rather than one-indexed in target names
Citation references are zero-indexed rather than one-indexed in target names
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Low trivial
: ---
Assigned To: Gabriel Wicke
: easy
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-12-18 16:41 UTC by James Forrester
Modified: 2013-07-04 10:33 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description James Forrester 2012-12-18 16:41:05 UTC 
In the current Parsoid integration (through the PHP parser) of the Citation extensions, its references are zero-indexed rather than one-indexed in target names - this means that the generated HTML from Parsoid looks (roughly) like:

<li id="cite_note-Foo-0" data-parsoid="…"><a href="#cite_ref-Foo-0-0" data-parsoid="…">↑</a>…</li>

... rather than:

<li id="cite_note-Foo-1"><a href="#cite_ref-Foo-1-0">↑</a>…</li>
Comment 1 Gabriel Wicke 2012-12-18 16:50:52 UTC 
Same reason as those other bugs: We are using our own Cite extension implementation (no PHP involved) that differs in details like these. Easy to adjust though.
Comment 2 Gabriel Wicke 2013-03-28 19:58:56 UTC 
Should be fixed by https://gerrit.wikimedia.org/r/#/c/55833/.
Comment 3 Andre Klapper 2013-07-04 10:33:43 UTC 
[Parsoid component reorg by merging JS/General and General. See bug 50685 for more information. Filter bugmail on this comment. parsoidreorg20130704]
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links