Last modified: 2006-01-15 17:43:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T6321, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 4321 - MediaWiki:Blockipsuccesstext messes up with spaces
MediaWiki:Blockipsuccesstext messes up with spaces
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-12-20 11:51 UTC by p_simoons
Modified: 2006-01-15 17:43 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description p_simoons 2005-12-20 11:51:14 UTC
MediaWiki:Blockipsuccesstext creates a URL containing $1 (the user name that was
blocked). Since a space is the delimeter between the actual URL and its
description (e.g. [http://someplace.net this link]), if the user name happens to
contain a space, the URL is not what you expect it to be.

A solution would be to have the software replace the spaces by underscores.
Comment 1 Brion Vibber 2005-12-20 20:26:41 UTC
It seems to be wikitext, with wiki links, so spaces should work fine.

'blockipsuccesstext' => '[[{{ns:Special}}:Contributions/$1|$1]] has been blocked.
<br />See[[{{ns:Special}}:Ipblocklist|IP block list]] to review blocks.',
Comment 2 p_simoons 2005-12-20 20:37:11 UTC
The phrase

[http://en.wikipedia.org/w/index.php?title=Special%3ALog&type=block&user=&page=User:$1
block log]

is a raw URL and doesn't work properly if $1 contains spaces.
Comment 3 Brion Vibber 2005-12-20 20:40:12 UTC
Then don't do that... ?
Comment 4 p_simoons 2005-12-20 21:03:41 UTC
Well, yes, good point. I was just wondering if there was an easy way to make $1
use underscores rather than spaces, but if thee isn't I won't bother you with it.
Comment 5 Brion Vibber 2005-12-20 21:04:38 UTC
Well, underscores isn't sufficient. You'd need a url-encoded version.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links