Last modified: 2006-02-03 04:04:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 4303 - Skin::initpage favicon issues
Skin::initpage favicon issues
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Installer (Other open bugs)
1.6.x
All All
: Normal trivial with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-12-17 11:32 UTC by T. Gries
Modified: 2006-02-03 04:04 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Implementing $wgFavicon (1.31 KB, patch)
2006-01-04 17:13 UTC, nekocue
Details

Description T. Gries 2005-12-17 11:32:04 UTC
Everytime after new installations, I have to patch function initpage.php in module Skin.php to adapt MediaWiki 
according to me needs- my wikis' favicons' live in their _script_ paths. 
 
To make it better configurable, I propose to implement one of two methods. 
 
(1) drop the constant filename in Skin::initpage and change it to become another variable $wgFaviconPath of 
DefaultSettings.php 
 
	function initPage( &$out ) { 
		... 
		global $wgFaviconPath 
		$out->addLink( array( 'rel' => 'shortcut icon', 'href' => $wgFaviconPath ) ); 
 
(2) (alternative method) change the filename to become dependent on the current $wgScriptPath, so that every Wiki 
installation can have its own favicon.ico in its script path 
 
	function initPage( &$out ) { 
		... 
		global $wgScriptPath; 
		$out->addLink( array( 'rel' => 'shortcut icon', 'href' => $wgScriptPath . '/favicon.ico' ) ); 
 
 
[ Because of the alternatives, I did not attach a regular patch file ]
Comment 1 T. Gries 2005-12-17 11:38:02 UTC
[corr]Everytime after new installations, I have to patch function initpage.php
in module Skin.php to adapt MediaWiki according to my needs - my wikis' favicons
live in their _script_ paths. 
Comment 2 Brion Vibber 2005-12-18 06:16:37 UTC
My inclination is to stick in a $wgFaviconPath.

The only reason we have the link tag in there is that Mozilla requires it to follow the 
preexisting (IE-based) /favicon.ico convention.
Comment 3 T. Gries 2005-12-18 09:59:26 UTC
(In reply to comment #2)
> My inclination is to stick in a $wgFaviconPath.
Brion: can you do so please ?
Comment 4 nekocue 2006-01-04 17:13:56 UTC
Created attachment 1259 [details]
Implementing $wgFavicon

Enables configuring favicon by changing $wgFavicon.

# I think $wgFavicon looks prettier with $wgLogo, rather than $wgFaviconPath.
Comment 5 Brion Vibber 2006-02-03 04:04:24 UTC
Applied to CVS HEAD for 1.6.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links