Last modified: 2010-05-15 15:38:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T6280, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 4280 - Old revisions should use 'noindex,nofollow' instead of 'noindex,follow' meta robots tag
Old revisions should use 'noindex,nofollow' instead of 'noindex,follow' meta ...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
1.5.x
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
http://www.pooshlmer.com/touhouwiki/i...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-12-14 23:57 UTC by ekim
Modified: 2010-05-15 15:38 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Diff file changing to nofollow (3.05 KB, text/plain)
2006-01-12 19:37 UTC, ekim
Details

Description ekim 2005-12-14 23:57:16 UTC
I turned off nofollow, but I thought it would still put nofollow on the old
history pages and diffs. There should be no reason for a history page to not
have the nofollow tag on links, since it defeats the purpose of policing the
wiki if the spam link is still valid.
Comment 1 ekim 2005-12-15 00:01:43 UTC
Forgot to mention that just the page could be marked as nofollow, which isn't
done either.
Comment 2 Rob Church 2005-12-15 13:47:05 UTC
So what exactly is it you want addressed? What did you do, and what did you
expect to happen? What happened, and how did it differ from what you expected?
Ergo, what would you like changed?

Neither of the comments above are particularly useful to us.
Comment 3 ekim 2005-12-15 16:33:20 UTC
All history and diff pages should be marked nofollow as well as noindex, no
matter what the setting of wgNoFollowLinks.
Comment 4 Ævar Arnfjörð Bjarmason 2005-12-15 16:35:07 UTC
(In reply to comment #3)
> All history and diff pages should be marked nofollow as well as noindex, no
> matter what the setting of wgNoFollowLinks.

Why should the $wgNoFollowLinks setting not matter for whether or not they got
nofollow?
Comment 5 ekim 2005-12-15 19:44:02 UTC
I thought the history pages were not meant for external display, but were just
for internal reference and vandalism fixes. If you don't set nofollow, search
engines will go to the history page and follow the link, which lets the spammers
have an effect even on an actively maintained wiki.

More stuff here:

http://wiki.chongqed.org/NoIndexHistory
Comment 6 Brion Vibber 2005-12-15 21:30:46 UTC
Changed bug summary to reflect the part that will make a 
difference. :)
Comment 7 ekim 2006-01-11 01:30:49 UTC
Sorry, don't have CVS here. Hopefully it's not too much of a pain.

Article.php:
758c758
<                               $wgOut->setRobotpolicy( 'noindex,follow' );
---
>                               $wgOut->setRobotpolicy( 'noindex,nofollow' );
1384c1384
<               $wgOut->setRobotpolicy( 'noindex,follow' );
---
>               $wgOut->setRobotpolicy( 'noindex,nofollow' );
1429c1429
<               $wgOut->setRobotpolicy( 'noindex,follow' );
---
>               $wgOut->setRobotpolicy( 'noindex,nofollow' );
1470c1470
<                       $wgOut->setRobotpolicy( 'noindex,follow' );
---
>                       $wgOut->setRobotpolicy( 'noindex,nofollow' );
1505c1505
<                       $wgOut->setRobotpolicy( 'noindex,follow' );
---
>                       $wgOut->setRobotpolicy( 'noindex,nofollow' );
DifferenceEngine.php:
131c131
<               $wgOut->setRobotpolicy( 'noindex,follow' );
---
>               $wgOut->setRobotpolicy( 'noindex,nofollow' );
253c253
<               $wgOut->setRobotpolicy( 'noindex,follow' );
---
>               $wgOut->setRobotpolicy( 'noindex,nofollow' );
SpecialPage.php:
249c249
<                                       $wgOut->setRobotpolicy( "noindex,follow"
 );
---
>                                       $wgOut->setRobotpolicy( "noindex,nofollo
w" );
364c364
<               $wgOut->setRobotPolicy( "noindex,follow" );
---
>               $wgOut->setRobotPolicy( "noindex,nofollow" );
Comment 8 Brion Vibber 2006-01-11 01:32:25 UTC
1) use 'diff -u' to create a unified diff; this includes context information vital to applying 
to a different version
2) attach the file, don't paste it into a comment
Comment 9 lɛʁi לערי ריינהארט 2006-01-11 02:56:21 UTC
*note*
Many spamed pages are reverted and the spam links are still in the old
revisions. One more reason to have "noindex,nofollow" for old revisions.
Comment 10 ekim 2006-01-12 19:37:30 UTC
Created attachment 1300 [details]
Diff file changing to nofollow
Comment 11 Ævar Arnfjörð Bjarmason 2006-01-12 19:41:11 UTC
Hardcoding this seems like the wrong way to do it, Wikimedia sites don't have
their histories indexed because we use a special prefix for them and simply
disallow that in robots.txt. Some wikis might want search engines to be able to
index their old revisions so either:

* Move your histories/other action!=view stuff off to a special prefix
* Provide a patch which doesn't hardcode nofollow on something some wikis might
want search engines to follow
Comment 12 ekim 2006-01-12 20:49:39 UTC
An option to allow it, then? I thought part of the point of doing nofollow was
to prevent spam from working on wikis set up by non-technical people, who don't
want to mess with that stuff.
Comment 13 Brion Vibber 2006-01-12 22:39:46 UTC
Hardcoding is correct; there's no real reason to have those marked with 'follow', and it 
could cause infinite loops etc.
Comment 14 Brion Vibber 2006-06-07 00:21:59 UTC
This seems to have been done for old page views a while ago. 
Added the rest (diffs, some special pages) in r14628.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links