Last modified: 2012-12-17 12:57:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T44294, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 42294 - Reverting to an old version of a video file does not trigger new transcodes


Summary:	Reverting to an old version of a video file does not trigger new transcodes

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	TimedMediaHandler (Other open bugs)
Version:	master
Hardware:	All All

Importance:	High normal (vote)
Target Milestone:	---
Assigned To:	Michael Dale

URL:	https://commons.wikimedia.org/wiki/Fi...
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-11-20 17:20 UTC by Marco
Modified:	2012-12-17 12:57 UTC (History)
CC List:	3 users (show)

See Also:	29179
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Marco 2012-11-20 17:20:49 UTC

Reverting a video to an older version ( https://commons.wikimedia.org/w/index.php?title=File%3ATmh.rev.test.ogv&diff=83339659&oldid=83296596 ) breaks the "thumbnails" ( example: https://upload.wikimedia.org/wikipedia/commons/thumb/1/14/Tmh.rev.test.ogv/Tmh.rev.test.ogv.360p.webm ) and does not trigger a new transcode.

Error message:

 Error generating thumbnail

 The specified thumbnail parameters are not recognized.

Comment 1 Jan Gerber 2012-11-21 15:22:27 UTC

looks like the files get purged but are still in the transcode table.

Comment 2 Marco 2012-11-21 19:06:12 UTC

Purging does not trigger new transcodes...

Comment 3 Jan Gerber 2012-11-21 19:10:46 UTC

purging is not supposed to trigger new transcodes, people with the right permissiosn can reset transcodes.

in case of a revert the transcodes should be reset. this does not happen currently. not able to test my fix right now since revert is completely broken in my local mediawiki.

Comment 4 db [inactive,noenotif] 2012-11-28 13:35:07 UTC

Merged Gerrit change #35151 links here, bug maybe resolved

Comment 5 Marco 2012-11-28 14:06:09 UTC

My test case still does not transcode.

Comment 6 Marco 2012-12-01 21:40:46 UTC

(In reply to comment #4)
> Merged Gerrit change #35151 links here, bug maybe resolved

The change got verified twice but as I said, reverting still produces the old behavior.

Comment 7 Marco 2012-12-08 12:34:00 UTC

What does the
 if ( $baseID !== false )
mean? Why is it necessary to check if $baseID is true?

Comment 8 Jan Gerber 2012-12-12 15:35:03 UTC

the patch is still not deployed on commons, it is deployed on https://test2.wikipedia.org/ now.

Comment 9 Marco 2012-12-12 17:06:30 UTC

Thank you for the info. Seems to work perfectly on test2.wiki.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links