Last modified: 2013-01-02 15:59:17 UTC
The link to Code Review on the personal portlet has been moved to the far right, after the Log out link. Probably introduced in 1.21wmf4
(In reply to comment #0) > The link to Code Review on the personal portlet URLs please, always. Thanks...
Platonides: Can you please provide a URL or steps to reproduce?
Indeed. MediaWiki core interface has no such "Code Review" link. What's this about?
That link appears on https://www.mediawiki.org/ (provided by Extension:CodeReview) but is no longer at the right. Some later update seems to have fixed it.
Extension:CodeReview adds no "Code Review" link in any portlet. There is one in the sidebar (configured in [[mw:MediaWiki:Sidebar]]) but nothing in the personal portlet. Where does the link point to?
It was (presumably) caused by a core change so don't blindly change it to CodeReview extension. By “personal portlet” I mean #p-personal (we are talking about different sections?) The link goes to http://www.mediawiki.org/wiki/Special:Code/MediaWiki Strangely, it seems to appear on vector but not on monobook.
Section #p-personal indeed. However there has never been such link in either core or the CodeReview extension.[1] I guess this is added by a gadget or a user script of yours. The position of the link is determined by the nextnode argument to addPortletLink. This logic hasn't changed since 1.17. So if it broke or was mispositioned it is likely due to the script that adds that link to your interface. [1] ext.CodeReview has one call to addPortletLink for the scapmap above table.TablePager for ext.codereview.overview. Nothing for p-personal.
Tricked by my own code! https://www.mediawiki.org/w/index.php?title=User:Platonides/vector.js&diff=349774&oldid=349723&diffonly=1 Still, that line has been unchanged since 2010. I suspect that #pt-userpage lost its id on November, thus having getElementById return null, and addPortletLink() put it at the end.
(In reply to comment #8) > Tricked by my own code! > https://www.mediawiki.org/w/index.php?title=User:Platonides/vector. > js&diff=349774&oldid=349723&diffonly=1 > > Still, that line has been unchanged since 2010. I suspect that #pt-userpage > lost its id on November, thus having getElementById return null, and > addPortletLink() put it at the end. My thoughts exactly. #pt-userpage was changed briefly during the 1.20/1.21 cycle.
