Last modified: 2012-11-28 14:03:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43390, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 41390 - It is possible to violate the label-description uniqueness constraint on items
It is possible to violate the label-description uniqueness constraint on items
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Highest normal (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-10-25 12:48 UTC by jeblad
Modified: 2012-11-28 14:03 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description jeblad 2012-10-25 12:48:00 UTC 
The uniqueness constraint on label-descriptions can now be violated. This is due to the function itself is modified in TermSqlCache::termsToConditions() (https://gerrit.wikimedia.org/r/#/c/25006/7/repo/includes/store/sql/TermSqlCache.php)

The function could be duplicated into a new with both the functionality of the old and new version of the code, or a new subclass can be made. In the first version a new TermSqlCache::getMatchingTerms() could be made to support it. In the second one the StoreFactory::newTermCache() must be changed.
Comment 1 Jeroen De Dauw 2012-10-31 20:52:40 UTC 
This is already fixed on master and we have test cases for it
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links