Last modified: 2006-01-17 21:27:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 4104 - render a text and its translation, on two columns
render a text and its translation, on two columns
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal enhancement with 6 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
http://thecircle.dyndns.org/wiki/inde...
: crosswiki, patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-11-28 20:42 UTC by ThomasV
Modified: 2006-01-17 21:27 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
patch: diff from cvs (5.81 KB, patch)
2005-11-28 20:44 UTC, ThomasV
Details
extension file (3.45 KB, text/plain)
2005-11-29 00:03 UTC, ThomasV
Details
diff from cvs, OutputPage.php (1.26 KB, patch)
2005-11-29 00:04 UTC, ThomasV
Details
extension file, corrected after brion's feedback (3.53 KB, text/plain)
2005-11-29 09:25 UTC, ThomasV
Details
extension file, new version after Brion's comments (3.88 KB, text/plain)
2005-11-29 10:41 UTC, ThomasV
Details
extension file (5.72 KB, text/plain)
2005-12-07 10:46 UTC, ThomasV
Details
extension file (10.25 KB, patch)
2005-12-11 16:46 UTC, ThomasV
Details
extension file, fixed null test (10.25 KB, patch)
2005-12-12 08:43 UTC, ThomasV
Details
extension file (10.55 KB, patch)
2005-12-21 22:24 UTC, ThomasV
Details
cvs diff -u OutputPage.php (1.05 KB, patch)
2006-01-09 17:23 UTC, ThomasV
Details
cvs diff -u OutputPage.php (1.13 KB, patch)
2006-01-11 21:28 UTC, ThomasV
Details
cvs diff -u docs/hooks.txt (451 bytes, patch)
2006-01-11 23:01 UTC, ThomasV
Details
cvs diff -u OutputPage.php (1.42 KB, patch)
2006-01-12 09:14 UTC, ThomasV
Details
cvs diff -u Article.php (684 bytes, patch)
2006-01-12 09:15 UTC, ThomasV
Details
cvs diff -u DoubleWiki.php (1.96 KB, patch)
2006-01-13 20:19 UTC, ThomasV
Details
cvs diff -u DoubleWiki.php (1.51 KB, patch)
2006-01-13 20:21 UTC, ThomasV
Details

Description ThomasV 2005-11-28 20:42:40 UTC
this patch displays an article and its translation on the same page, on two
columns. the translation is supposed to be accessible through an 
interlanguage link.

the patch was primarily written for Wikisource, although other projects might
find it useful.
Comment 1 ThomasV 2005-11-28 20:44:36 UTC
Created attachment 1110 [details]
patch: diff from cvs
Comment 2 Brion Vibber 2005-11-28 20:47:10 UTC
Very ugly hack!

Should:
1) be an extension
2) use action=render
3) be careful about which interwikis are allowed (security issues?)
Comment 3 ThomasV 2005-11-28 23:47:42 UTC
thanks for your feedback.

1: I made it an extension, but I had to add new hooks to Outputpages.php. I
think that I cannot use the existing hooks in Parser.php, because of the cache.
Is that a problem? 

2: done

3: Interwikis are defined by the admin of the wiki. I am not sure if there is a
way to control that. any suggestion?
Comment 4 ThomasV 2005-11-29 00:03:43 UTC
Created attachment 1112 [details]
extension file
Comment 5 ThomasV 2005-11-29 00:04:59 UTC
Created attachment 1113 [details]
diff from cvs, OutputPage.php
Comment 6 ThomasV 2005-11-29 09:25:47 UTC
Created attachment 1114 [details]
extension file, corrected after brion's feedback
Comment 7 ThomasV 2005-11-29 10:41:08 UTC
Created attachment 1115 [details]
extension file, new version after Brion's comments
Comment 8 ThomasV 2005-12-07 10:46:45 UTC
Created attachment 1151 [details]
extension file

improved some regular expressions, added matching of h2 and h3 subtitles
Comment 9 ThomasV 2005-12-11 16:46:14 UTC
Created attachment 1171 [details]
extension file

Now generates valid html, assuming that input pages are themselves valid.
Comment 10 ThomasV 2005-12-12 08:43:45 UTC
Created attachment 1176 [details]
extension file, fixed null test
Comment 11 ThomasV 2005-12-20 13:59:13 UTC
could some developer review/commit this code? 
apparently brion is too busy with other 
things, he said he has no time. 

I have been waiting for quite some time, 
and I do not know to whom I should ask.

what should I do?
Comment 12 ThomasV 2005-12-21 22:24:07 UTC
Created attachment 1225 [details]
extension file

minor fixes
Comment 13 Brion Vibber 2005-12-24 01:08:15 UTC
Committed to extensions CVS.
Comment 14 ThomasV 2006-01-09 17:23:16 UTC
Created attachment 1278 [details]
cvs diff -u OutputPage.php 

You did not commit the patch for OutputPage.php. It adds a hook used by the
extension. 

Here is an updated version of the patch, since recent changes to OutputPage.php
deprecate the previous one.
Comment 15 ThomasV 2006-01-11 21:28:05 UTC
Created attachment 1289 [details]
cvs diff -u OutputPage.php
Comment 16 ThomasV 2006-01-11 23:01:36 UTC
Created attachment 1290 [details]
cvs diff -u docs/hooks.txt
Comment 17 Brion Vibber 2006-01-12 02:54:30 UTC
As discussed in chat, the hook isn't quite right; breaks when parser cache is not used.
Comment 18 ThomasV 2006-01-12 09:14:09 UTC
Created attachment 1296 [details]
cvs diff -u OutputPage.php
Comment 19 ThomasV 2006-01-12 09:15:21 UTC
Created attachment 1297 [details]
cvs diff -u Article.php 

call AddPrimaryWikiText instead of AddWikiText
Comment 20 ThomasV 2006-01-13 20:19:09 UTC
Created attachment 1303 [details]
cvs diff -u DoubleWiki.php

debugging code
Comment 21 ThomasV 2006-01-13 20:21:26 UTC
Created attachment 1304 [details]
cvs diff -u DoubleWiki.php

oops
Comment 22 lɛʁi לערי ריינהארט 2006-01-13 21:01:17 UTC
changing url to include match=foo
Comment 23 ThomasV 2006-01-17 21:27:16 UTC
works. thanks, brion!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links