Last modified: 2012-04-20 17:54:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T6045, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 4045 - BiDi: Embed links for parent pages according to content language
BiDi: Embed links for parent pages according to content language
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
unspecified
All All
: Low normal with 1 vote (vote)
: ---
Assigned To: Amir E. Aharoni
http://yi.wikipedia.org/wiki/user:Gan...
:
Depends on:
Blocks: 4040
  Show dependency treegraph
 
Reported: 2005-11-21 07:35 UTC by lɛʁi לערי ריינהארט
Modified: 2012-04-20 17:54 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description lɛʁi לערי ריינהארט 2005-11-21 07:35:27 UTC
I opened the request from bug 4040 as an individual bug.

Please look at the links to the "parent pages" at
[[yi:user:Gangleri/tests/TOC_and_sections]]. There the links overlap.

The links should be embeded as:
‫[[באַניצער:Gangleri]]‬ | ‫[[באַניצער:Gangleri/tests|tests]]‬

regards reinhardt [[user:gangleri]]
Comment 1 lɛʁi לערי ריינהארט 2005-12-21 09:50:35 UTC
changed summary to emphasize the todo's:
new summary: BiDi: Embed links for parent pages according to content language

(In reply to comment #0)
> I opened the request from bug 4040 as an individual bug.Please look at the links to 
the "parent pages" at[[yi:user:Gangleri/tests/TOC_and_sections]]. There the links overlap.

*details*
If you move the mouse either on
באַניצער
or on
Gangleri
you will see that the link is "interrupted" by "tests".

I think it should be a general rule that links should be generated only by consecutive 
characters only.

> The links should be embeded as:‫[[באַניצער:Gangleri]]‬ | ‫[[באַניצער
:Gangleri/tests|tests]]‬regards reinhardt [[user:gangleri]]

Please use a method which is suitable for the most browsers. We should use the same method 
for all such / similar fixes. See how bug bug 3922 is implemented.
bug 3922: links are not properly rendered in a BiDi category list

*providing more testcases*
a) http://ar.wikipedia.org/w/index.php?oldid=129120
http://ar.wikipedia.org/w/index.php?title=user:Gangleri/tests/BiDi/%D9%85%D8%B3%D8%AA%D8%AE%
D8%AF%D9%85_M%C3%BCnchen_%28%D9%85%D9%8A%D9%88%D9%86%D8%AE%29/foo/bar&oldid=129120

there "Gangleri" is in the middle; there are parent pages to the left and to the right of it

b) http://ar.wikipedia.org/w/index.php?oldid=129113
http://ar.wikipedia.org/w/index.php?title=user:Gangleri/tests/BiDi/%D9%85%D8%B3%D8%AA%D8%AE%
D8%AF%D9%85_%D9%85%D9%8A%D9%88%D9%86%D8%AE_%28M%C3%BCnchen%29/foo/bar&oldid=129113

there you can see two overlappings according to the BiDi algorithm; move the mouse on "foo" 
or "Gangleri"; what looks very odd is that between the two "|" characters located leftmost 
and rightmost to "foo" there are other characters as well
Comment 2 lɛʁi לערי ריינהארט 2006-03-22 21:38:33 UTC
Test cases are available at
http://www.anubite.co.uk/mediawiki/head-rtl/index.php/category:Bugzilla/04045
a RTL wiki mirrored at another LTR wiki
http://www.anubite.co.uk/mediawiki/head/index.php/category:Bugzilla/04045

*note*
The page title at
http://www.anubite.co.uk/mediawiki/head-rtl/index.php/user:Gangleri/bugzilla_report_/_04045_/_%D7%90_a_/_b_%D7%91
looks like a puzzle. This is what the bidirectional algorithm does with such
mixed LTR and RTL charactes.

Thanks Rob!
Comment 3 lɛʁi לערי ריינהארט 2006-03-22 21:59:10 UTC
*note*
The title of
http://www.anubite.co.uk/mediawiki/head-rtl/index.php/user:Gangleri/bugzilla_report_/_04045_/_a_b_/_%D7%90_%D7%91_/_%21
משתמש:Gangleri/bugzilla report / 04045 / a b / א ב / !
displays as
‏משתמש:Gangleri/bugzilla report / 04045 / a b / א ב / !‏

However if you know how to copy the page title from the url above you may copy
and wikify it. This is why directionality of titles should *not* be tuched.

best regards reinhardt [[user:gangleri]]
Comment 4 Robin Pepermans (SPQRobin) 2011-08-03 10:17:20 UTC
We would have to change the message 'pipe-separator' from ' | ' to ' ‫|‫ ' for RTL interface and ' ‪|‪ ' for LTR interface, but the problem is how to make the message dependent on the direction of the interface.
Comment 5 Amir E. Aharoni 2012-04-18 15:59:10 UTC
Fix committed in https://gerrit.wikimedia.org/r/#change,5231 .

(Thanks a million to hashar for cleaning up the Git mess that was involved in committing this simple little patch...)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links