Last modified: 2012-12-03 22:46:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42339, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 40339 - VisualEditor: Un-listing when the caret is at the end of the document throws an error
VisualEditor: Un-listing when the caret is at the end of the document throws ...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2012-12-10
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-18 22:35 UTC by James Forrester
Modified: 2012-12-03 22:46 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description James Forrester 2012-09-18 22:35:30 UTC

    
Comment 1 James Forrester 2012-10-01 18:28:46 UTC
Details:

Uncaught TypeError: Cannot read property 'annotations' of undefined ve.dm.Document.js:529
> ve.dm.Document.getAnnotationsFromOffset ve.dm.Document.js:529
> ve.dm.Surface.change ve.dm.Surface.js:123
> ve.ui.ListButtonTool.unlist ve.ui.ListButtonTool.js:161
> ve.ui.ListButtonTool.onClick ve.ui.ListButtonTool.js:177
> VeUiButtonTool.tool.$.on.mouseup ve.ui.ButtonTool.js:40
> jQuery.event.dispatch load.php:3060
> elemData.handle.eventHandle
Comment 2 Rob Moen 2012-10-01 23:34:35 UTC
The correct stack error for this is:
Uncaught TypeError: Cannot read property 'html/data-parsoid' of undefined ve.js:357
ve.compareObjects ve.js:357
ve.dm.Transaction.newFromContentBranchConversion ve.dm.Transaction.js:284
ve.ui.ListButtonTool.list ve.ui.ListButtonTool.js:66
ve.ui.ListButtonTool.onClick ve.ui.ListButtonTool.js:175
VeUiButtonTool.tool.$.on.mouseup ve.ui.ButtonTool.js:40
jQuery.event.dispatch load.php:3060
jQuery.event.add.elemData.handle.eventHandle

Fixed in https://gerrit.wikimedia.org/r/25974
Comment 3 James Forrester 2012-10-15 18:43:46 UTC
Confirmed still an issue.
Comment 4 James Forrester 2012-11-13 18:41:18 UTC
Pushing to next milestone as they did not make it to master by yesterday.
Comment 5 Roan Kattouw 2012-11-17 01:19:32 UTC
Reassigning to Trevor because Rob is out
Comment 6 James Forrester 2012-11-27 23:38:33 UTC
Confirmed still a problem in master as of 2012-11-27; now is a properly-thrown error from ve.dm.Document.prototype.getNodeFromOffset:

Uncaught Error: ve.dm.Document.getNodeFromOffset(): offset 26 is out of bounds ve.dm.Document.js:546
ve.dm.Document.getNodeFromOffset ve.dm.Document.js:546
ve.dm.Surface.change ve.dm.Surface.js:212
ve.ce.Surface.onSelectionChange ve.ce.Surface.js:260
[...]
Comment 7 James Forrester 2012-12-03 22:46:22 UTC
Fixed in Gerrit change #36597.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links