Last modified: 2006-06-22 10:36:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 4033 - Style dir fixed in Skin.php
Style dir fixed in Skin.php
Status: VERIFIED FIXED
Product: MediaWiki
Classification: Unclassified
Installer (Other open bugs)
1.6.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://wikipedia.sourceforge.net/doc/...
:
: 5960 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-11-19 17:02 UTC by Jelte (WebBoy)
Modified: 2006-06-22 10:36 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Fixed User.php and Skin.php (MediaWiki 1.5.2) (19.15 KB, application/rar)
2005-11-21 19:27 UTC, Jelte (WebBoy)
Details
Patch for Skin.php (1.31 KB, patch)
2006-01-14 14:19 UTC, Jelte (WebBoy)
Details

Description Jelte (WebBoy) 2005-11-19 17:02:45 UTC
The Style-directory is fixed in includes/User.php as $IP.'/skins'. This should
be $wgStyleDirectory.
Comment 1 Jelte (WebBoy) 2005-11-19 17:18:50 UTC
Same in includes/Skin.php:

$skinDir = dir($IP.'/skins');
should be
$skinDir = dir($wgStyleDirectory);
Comment 2 Rob Church 2005-11-20 00:26:29 UTC
Neither $wgStyleDirectory nor any other of those types of variables have a value
at the time that $IP is set. Closing not valid, as there's a reason $IP is like
it is.
Comment 3 Jelte (WebBoy) 2005-11-20 11:05:12 UTC
$IP is set in LocalSettings.php, $wgStyleDirectory is set in LocalSettings.php
AND DefaultSettings.php, what’s the differance?

Also the chances in Skin.php and User.php work for me.
(Don't forget to change
    global $IP, $wgRequest;
to
    global $wgStyleDirectory, $wgRequest;
in function &getSkin()) 
Comment 4 Rob Church 2005-11-20 15:09:33 UTC
They're set much later. $IP is a special case and is done like that *for a reason.*
Comment 5 Jelte (WebBoy) 2005-11-21 19:16:13 UTC
I have changed and tested it on my testwiki and I works whitout warnings. So
it's possible to change!

(PS Use RESOLVE WONTFIX next time.)
Comment 6 Jelte (WebBoy) 2005-11-21 19:27:35 UTC
Created attachment 1089 [details]
Fixed User.php and Skin.php (MediaWiki 1.5.2)

See attachment for fixed User.php and Skin.php (For MediaWiki 1.5.2)
Comment 7 Jelte (WebBoy) 2006-01-14 13:15:59 UTC
User.php is fixed in version 1.198, Mon Dec 19 23:36:43 2005 UTC
Comment 8 Jelte (WebBoy) 2006-01-14 13:18:04 UTC
Making a patch for Skin.php...
Comment 9 Jelte (WebBoy) 2006-01-14 14:19:06 UTC
Created attachment 1307 [details]
Patch for Skin.php

Patch for Skin.php - tested on own wiki
Comment 10 Rob Church 2006-05-28 23:09:30 UTC
*** Bug 5960 has been marked as a duplicate of this bug. ***
Comment 11 Rob Church 2006-05-28 23:13:17 UTC
Fixed in SVN trunk, r14449.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links