Last modified: 2005-11-18 10:16:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 4014 - In Allpages wrong parameters passed in call to showChunk
In Allpages wrong parameters passed in call to showChunk
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.6.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-11-17 18:37 UTC by Roddy MacFarquhar
Modified: 2005-11-18 10:16 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roddy MacFarquhar 2005-11-17 18:37:28 UTC
In the call to showChunk from showTopLevel four parameters are passed but showChunk only takes 
three - and extra false is included which means that the $including flag is not passed correctly 
and when Special:Allpages is included and there are only a small number of pages it shows the 
navigation form when it shouldn't.

Suggested fix - remove the false in the call to showChunk below

	// If there are only two or less sections, don't even display them.
	// Instead, display the first section directly.
	if( count( $lines ) <= 2 ) {
		$this->showChunk( $namespace, '', false, $including );
		return;
	}
Comment 1 Brion Vibber 2005-11-18 10:08:24 UTC
It looks ok to me...

		$this->showChunk( $namespace, '', false, $including );
Comment 2 Brion Vibber 2005-11-18 10:09:12 UTC
Oh wait, the code sample above is *wrong* instead of the suggested fix. Blaaaaahhh...
Comment 3 Brion Vibber 2005-11-18 10:16:15 UTC
Fixed in CVS HEAD.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links