Last modified: 2005-11-27 10:26:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 3979 - {{REVISIONID}} is broken until page is purged
{{REVISIONID}} is broken until page is purged
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on:
  Show dependency treegraph
Reported: 2005-11-15 19:05 UTC by lɛʁi לערי ריינהארט
Modified: 2005-11-27 10:26 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

screen dump for bug 03979 (19.33 KB, image/jpeg)
2005-11-15 19:06 UTC, lɛʁi לערי ריינהארט
{{REVISIONID}} fix patch (595 bytes, patch)
2005-11-25 16:40 UTC, Tietew
Patch to Parser.php, Article.php, OutputPage.php (6.46 KB, patch)
2005-11-27 05:35 UTC, Brion Vibber
Patch to Parser.php, Article.php, OutputPage.php, DifferenceEngine.php (7.51 KB, patch)
2005-11-27 06:02 UTC, Brion Vibber

Description lɛʁi לערי ריינהארט 2005-11-15 19:05:53 UTC

sceen dump from follows

{{REVISIONID}} is broken. Before {{REVISIONID}} was showing 0 in preview which
was fine for me.

Now {{REVISIONID}} will not show in preview any more *and* it will not show
after saving *unless* the page is purged. This makes no sense to me.

Tray to edit
making minor changes. Just add some dots at the end and save.

If you see a red {{REVISIONID}} tray to purge the page.

regards reinhardt [[user:gangleri]]
Comment 1 lɛʁi לערי ריינהארט 2005-11-15 19:06:29 UTC
Created attachment 1070 [details]
screen dump for bug 03979
Comment 2 lɛʁi לערי ריינהארט 2005-11-15 20:28:16 UTC
{{REVISIONID}} originaly designed as a variable
is now shown in
"Templates used on this page:"

Comment 3 Zoran Obradovic 2005-11-25 16:08:33 UTC
This makes {{REVISIONID}} useless until it's fixed.
Comment 4 Tietew 2005-11-25 16:40:36 UTC
Created attachment 1100 [details]
{{REVISIONID}} fix patch
Comment 5 Brion Vibber 2005-11-25 22:43:44 UTC
Patch doesn't appear to fix the bug. It seems to cause it to show '0' instead of a 
'Template:REVISIONID' link, but it still is storing the wrong version number in the 
parser cache: 0 for new pages, and the previous revision for edited pages.

A correct fix probably will require updating the article's ID number after the revision 
is saved and before the text is parsed (which goes to the link cache and, now, gets 
saved in the parser cache.)
Comment 6 Brion Vibber 2005-11-27 04:31:37 UTC
Removing patch keywords for the moment, as patch doesn't fix the problem.
Comment 7 Brion Vibber 2005-11-27 05:35:48 UTC
Created attachment 1105 [details]
Patch to Parser.php, Article.php, OutputPage.php

This patch:
* Removes $wgArticle dependency from Parser's {{REVISIONID}} handling
* Adds an optional parameter on Parser::parse() for revision id
* Wraps that with OutputPage::setRevisionId()
* Adds appropriate calls on Article::view and Article::showArticle, which
passes the newly inserted id number from page save

It seems to properly handle both page creation and update. Also it will be an
easy way for special pages which deal with external-page text to poke in a
revision id number.
Comment 8 Brion Vibber 2005-11-27 06:02:03 UTC
Created attachment 1106 [details]
Patch to Parser.php, Article.php, OutputPage.php, DifferenceEngine.php

Compared to previous version:
* Removes hook for revision ID override, can now set that directly
* Removes debugging statements ;)
* Sets revision ID in diff rendered-text display
Comment 9 Brion Vibber 2005-11-27 08:30:28 UTC
Fixed in HEAD for 1.6.
Comment 10 lɛʁi לערי ריינהארט 2005-11-27 10:26:59 UTC
Thanks a lot!

Note You need to log in before you can comment on or make changes to this bug.