Last modified: 2014-01-03 15:47:11 UTC
The CodeEditor extension should support activating the editor on JS and CSS pages on a MediaWiki wiki. I believe this is a matter of checking isJsorCssPage() or something similar. I also believe this is relatively straightforward to implement, so I'm marking this as easy. I think there's a reasonable expectation that enabling this extension will affect JS and CSS pages on the wiki (plus the editor can easily be toggled off), but I guess you could put this particular feature behind a global configuration variable, if you wanted to.
With CE now being available for Module: pages, it's especially frustrating that it can't be used for JS and CSS. Brad, if it's easy, maybe something you'll have time to take on? If not, I'll ask Rob to find an assignee.
It looks like it's just a matter of not setting $wgCodeEditorEnableCore = false in CommonSettings.php. Are there any outstanding issues that we don't want to turn this on yet? Looking at the list of open bugs, possibly bug 47235 and bug 39557. I'll put it on the agenda for the MW Core team meeting tomorrow.
(In reply to comment #2) > I'll put it on the agenda for the MW Core team meeting tomorrow. Results from the meeting: I'll look at bug 47235 tomorrow, and bug 39557 doesn't seem like a blocker. Assuming that goes well, we'll look at deploying sometime next week.
(In reply to comment #3) > Results from the meeting: I'll look at bug 47235 tomorrow, and bug 39557 > doesn't seem like a blocker. Assuming that goes well, we'll look at deploying > sometime next week. Cool. This sounds good. This bug blocks bug 39654, which in turn has a few dependencies (bug 42577—which I still think is a duplicate of this bug—and bug 39616). There are also the open CodeEditor bugs to consider: <https://bugzilla.wikimedia.org/buglist.cgi?component=CodeEditor&product=MediaWiki%20extensions>, though I imagine most of these bugs have a higher likelihood of being resolved if this bug is resolved first. I like your plan.
Related URL: https://gerrit.wikimedia.org/r/62814 (Gerrit Change I39c626d066797d887769c3715df88838e709d527)
Brad: can you take another look at this bug? https://gerrit.wikimedia.org/r/62814 was successfully merged and deployed. The bug mentioned in its commit summary (bug 47235) has been marked resolved/fixed. Copying Greg on this bug report to hopefully get this bug moving forward.
We discussed it in the MW Core team meeting on Monday, as far as I'm concerned it's waiting on announcements and deployment windows.
Thanks Brad. Let's get it setup as it would be on production in the beta cluster asap. Test it out there and we can hopefully enable it on test/test2/mediawiki.org tomorrow. Then announce tomorrow for people to bang on it. Then enable next Thursday.
(In reply to comment #8) > Let's get it setup as it would be on production in the beta cluster asap. Isn't it already, as of Gerrit change #64587? Or was there something we wanted to do differently and I just forgot?
Oh, I didn't realize.... Testing.... Seems to work decently for me. :-) Since we haven't communicated it yet: * Let's turn it on in the test wiki group tomorrow (Thu). ** Brad, can you submit a quick config change for this and add myself and Reedy as reviewers? * I'll announce it as a part of the weekly deploy highlights email for next week * We'll turn it on for everywhere on next Thursday (29th) I've updated the Deployments wikipage with the date (we'll just do it as a part of the MediaWiki rollout that day). CC'ing Reedy for that reason now.
Change 80366 had a related patch set uploaded by Anomie: Enable CodeEditor for CSS/JS on testing wikis https://gerrit.wikimedia.org/r/80366
Change 80366 merged by jenkins-bot: Enable CodeEditor for CSS/JS on testing wikis https://gerrit.wikimedia.org/r/80366
(In reply to comment #10) > * I'll announce it as a part of the weekly deploy highlights email for next > week http://lists.wikimedia.org/pipermail/wikitech-l/2013-August/071453.html
*** Bug 39654 has been marked as a duplicate of this bug. ***
*** Bug 42577 has been marked as a duplicate of this bug. ***
I guess we can call this resolved now.
