Last modified: 2014-07-05 19:03:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41507, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 39507 - Upload by URL fails without giving any error
Upload by URL fails without giving any error
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Uploading (Other open bugs)
1.20.x
All All
: Low normal (vote)
: ---
Assigned To: Rohan Rawat
https://gerrit.wikimedia.org/r/gitweb...
: testme
Depends on:
Blocks: 39480
  Show dependency treegraph
 
Reported: 2012-08-20 17:12 UTC by Nemo
Modified: 2014-07-05 19:03 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nemo 2012-08-20 17:12:26 UTC
Whatever file I try to upload via upload_by_url on translatewiki.net, nothing happens: Special:Upload is reloaded as is, no error is shown.
Telling MediaWiki to ignore errors doesn't help and it's the same if there are no local or remote duplicates.
Note that this is different from bug 22015 because no error at all is shown (debug=true didn't help).
It might also be a configuration error.
Comment 1 Andre Klapper 2012-12-17 14:27:16 UTC
Nemo: Is this still an issue?
Comment 2 Nemo 2012-12-17 14:46:09 UTC
(In reply to comment #1)
> Nemo: Is this still an issue?

Why shouldn't it? It was only 4 months ago. :)
I can no longer test it because TWN doesn't have upload by URL enabled now.
Comment 3 Woozle 2013-01-20 22:21:18 UTC
I'm having the same problem with MW 1.20.2, and I have only the vaguest clue as to where to start debugging it because apparently the POST data is not handled inside SpecialUpload.php but somewhere else entirely (possibly the SpecialPage class).
Comment 4 Nemo 2013-01-20 23:03:07 UTC
Could this be yet another thing related to/fixed by Ia6535f1090627ef2def360bda37c22bff10c7f31 ?
Bug 44135 and bug 42441 all have in common some external request.
Comment 5 Woozle 2013-01-22 02:47:39 UTC
I'm experiencing this on a site not using https/SSL or Commons, fwiw. (I did have "$wgUseInstantCommons = true;", but after commenting that line out there does not appear to be any change in behavior.)

Tentatively, the problem may be in includes/upload/UploadBase.php or UploadFromURL.php.
Comment 6 Woozle 2013-01-27 19:02:17 UTC
The problem seems to be that the form shows the necessary controls for uploading by URL even if the user does not have permission to do so, while the code for processing the form fails silently if the user does not have permission (perhaps assuming that the necessary controls would ''not'' display in this case, in which case this condition could only be the result of a deliberate hack).

To reproduce this bug, then, all you have to do is have $wgAllowCopyUploads set TRUE and then attempt an upload while logged in as a user who does not have upload_by_url permission.

Suggested remedy: display a message indicating that the user doesn't have the upload_by_url permission, and link to this page for further explanation: https://www.mediawiki.org/wiki/Manual:$wgAllowCopyUploads
Comment 7 Nemo 2013-01-27 20:32:21 UTC
It's possible that this is already fixed in master, then: this would explain why in comment 2 I didn't see it enabled any longer, although I don't recall any related config change.
Comment 8 Brad Will (tmbw.net) 2013-05-01 16:15:06 UTC
I agree with Woozle's comment.  At the very least, an error message with some details will help people to determine the issue.  When I ran into this issue, I had to research it on mediawiki.org (and of course the documentation was out of date).  It required a lot of playing around with various configurations until I got it to work properly.
Comment 9 Nemo 2013-05-01 16:20:57 UTC
Brad, thank you. The default config should work for you, did you really have to set upload_by_url to * for it to work? http://tmbw.net/wiki/Special:ListGroupRights
Comment 10 Brad Will (tmbw.net) 2013-05-01 16:47:34 UTC
When I upgraded to 1.20.3, I first added "$wgCopyUploadsFromSpecialUpload = true;" to my LocalSettings.php file.  However, when I then tried to enter a source url and upload, the upload form would simply refresh (without any kinds of errors).

I then added "$wgGroupPermissions['*']['upload_by_url'] = true;" to my LocalSettings.php and that fixed it.

(Note - I just re-tested this, by temporarily commenting out the $wgGroupPermissions value, and this is definitely the behaviour on my wiki.)
Comment 11 Mark A. Hershberger 2014-06-21 19:57:53 UTC
Removing target milestone that was in the past.

If you want this in a specific release, have a good reason AND you are willing to find resources to fix this bug, feel free to change it to something appropriate.
Comment 12 Gerrit Notification Bot 2014-06-25 16:45:13 UTC
Change 142000 had a related patch set uploaded by Rohan013:
Disables upload by url option for users without the necessary permissions

https://gerrit.wikimedia.org/r/142000
Comment 13 Gerrit Notification Bot 2014-07-05 18:24:56 UTC
Change 142000 merged by jenkins-bot:
Disables upload by url option for users without the necessary permissions

https://gerrit.wikimedia.org/r/142000
Comment 14 Umherirrender 2014-07-05 19:03:12 UTC
was successfully merged

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links