Last modified: 2012-11-29 13:24:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41428, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 39428 - undo/restore may fail due to sitelink conflicts
undo/restore may fail due to sitelink conflicts
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: Normal enhancement (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks: 37683
  Show dependency treegraph
 
Reported: 2012-08-16 14:05 UTC by Daniel Kinzler
Modified: 2012-11-29 13:24 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel Kinzler 2012-08-16 14:05:13 UTC
If item A once linked to dewiki:Foo but now links to dewiki:Bar, and item B now links to dewiki:Foo, item A can not be restored to the old revision that points to dewiki:Foo.

This type of global-consistency conflict should be checked when preparing the undo/restore operation, just like "local" conflicts that arise from later edits of the item. The respective change to the sitelinks should be omitted, and this should be reported to the user.

Implementation note: care should be taken that this works on the restore as well as the undo codepath - the restore codepath so far bypasses checks for conflicting edits.

Reminder: fix broken error message that is shown when a sitelink conflict causes save to fail.
Comment 1 Daniel Kinzler 2012-08-19 20:02:46 UTC
see also bug 38958 for filtering based on global consistency constraints.
Comment 2 Daniel Kinzler 2012-08-29 15:42:27 UTC
Confirmed that undo/restore fails if a conflict would arise, but no database inconsistencies arise from this, and a meaningful error is shown to the user.

Automatically filtering out conflicting things from the item remains as a feature request.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links