Last modified: 2010-05-15 15:38:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 3933 - Atom feed doesn't specify namespace for feed element
Atom feed doesn't specify namespace for feed element
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.5.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-11-12 00:36 UTC by Myk Melez
Modified: 2010-05-15 15:38 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
patch v1: fixes bug in Feed.php (880 bytes, patch)
2005-11-12 01:02 UTC, Myk Melez
Details
patch v2: updated to 1.5 release branch (773 bytes, patch)
2005-11-12 01:14 UTC, Myk Melez
Details

Description Myk Melez 2005-11-12 00:36:10 UTC
The Atom version of the Special:Recentchanges page doesn't specify a namespace
for the feed element.  It generates the following feed tag:

<feed version="0.3" xml:lang="en">

Whereas it should generate the following tag:

<feed version="0.3" xmlns="http://purl.org/atom/ns#" xml:lang="en">

... per the Atom 0.3 spec:
http://www.mnot.net/drafts/draft-nottingham-atom-format-02.html

Because of this bug, feed validators like feedvalidator.org say the feed is invalid:

http://feedvalidator.org/check.cgi?url=http%3A%2F%2Fwiki.mozilla.org%2Findex.php%3Ftitle%3DSpecial%3ARecentchanges%26feed%3Datom

More importantly, some feed readers don't see the feed as an Atom feed, so they
don't parse it correctly.
Comment 1 Myk Melez 2005-11-12 01:02:43 UTC
Created attachment 1057 [details]
patch v1: fixes bug in Feed.php

This one-liner adds the necessary namespace attribute.	Note that I've applied
this patch to wiki.mozilla.org, so the feedvalidator URL above won't show the
error anymore.	But other wiki sites, like wikitravel, do show the error. 
Here's what the feed validator says about wikitravel:

http://feedvalidator.org/check.cgi?url=http%3A%2F%2Fwikitravel.org%2Fwiki%2Fen%2Findex.php%3Ftitle%3DSpecial%3ARecentchanges%26feed%3Datom
Comment 2 Myk Melez 2005-11-12 01:14:32 UTC
Created attachment 1058 [details]
patch v2: updated to 1.5 release branch

The previous patch was against our 1.4 installation, and it doesn't apply
cleanly to 1.5.  This patch does.  Note that neither patch is necessary on the
trunk, as the trunk is using Atom 1.0, and its feed tag is labeled with the
appropriate namespace attribute.
Comment 3 Brion Vibber 2005-11-16 08:51:28 UTC
Applied to REL1.5, will be in 1.5.3.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links