Last modified: 2014-09-14 17:16:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T41212, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 39212 - CentralNotice banner paging needs to be aware of banner filtering
CentralNotice banner paging needs to be aware of banner filtering
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CentralNotice (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Andrew Green
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-09 21:41 UTC by Matt Walker
Modified: 2014-09-14 17:16 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matt Walker 2012-08-09 21:41:07 UTC
Although the first page of any banner pager view will have the filter applied, moving to any other page (or clicking any link in the pager) will remove the filter.

Somehow we need to inform the pager that it can in fact add an additional GET string to the URI to re-add the filter on page move.
Comment 1 Peter Coombe 2013-10-24 16:34:28 UTC
Raising to normal, this is a semi-regular annoyance for me. Probably related to bug 53753
Comment 2 Andrew Green 2014-07-30 21:21:09 UTC
Interestingly, on my local install, the filter remains set when I move from one page to another. But the bug is indeed present as reported on Meta.

CentralNotice stores the last filter value in session data:

https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FCentralNotice/78f46af3e95aabe94286b6e830a07bbaace685b2/special%2FSpecialCentralNoticeBanners.php#L34

https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FCentralNotice/78f46af3e95aabe94286b6e830a07bbaace685b2/special%2FSpecialCentralNotice.php#L1522

Maybe something about caching in production gets in the way?
Comment 3 Gerrit Notification Bot 2014-08-04 01:40:40 UTC
Change 151568 had a related patch set uploaded by AndyRussG:
Fix banner name filter and put it in URLs

https://gerrit.wikimedia.org/r/151568
Comment 4 Gerrit Notification Bot 2014-08-04 18:02:36 UTC
Change 151568 merged by jenkins-bot:
Fix banner name filter and put it in URLs

https://gerrit.wikimedia.org/r/151568
Comment 5 Gerrit Notification Bot 2014-08-20 19:14:51 UTC
Change 155318 had a related patch set uploaded by Awight:
Fix banner name filter and put it in URLs

https://gerrit.wikimedia.org/r/155318
Comment 6 Gerrit Notification Bot 2014-08-20 19:17:54 UTC
Change 155318 merged by Ejegg:
Fix banner name filter and put it in URLs

https://gerrit.wikimedia.org/r/155318

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links