Last modified: 2014-02-12 23:45:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T40104, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 38104 - __NOTOC__ and/or home made ToC
__NOTOC__ and/or home made ToC
Status: RESOLVED WONTFIX
Product: MobileFrontend
Classification: Unclassified
Feature requests (Other open bugs)
unspecified
All All
: Unprioritized enhancement
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-01 23:12 UTC by Derk-Jan Hartman
Modified: 2014-02-12 23:45 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Derk-Jan Hartman 2012-07-01 23:12:32 UTC
This page uses NOTOC keyword and then manually creates a ToC using a few templates.

http://en.wikipedia.org/wiki/List_of_minor_planets:_28001–29000
http://en.m.wikipedia.org/wiki/List_of_minor_planets:_28001–29000


1: In my opinion, the mobilefrontend should always add the mw-mf-toc HTML, so apps and web can use it.
2: Two, it should strip 'home made' ToC's, as much as standard ToCs (share ID and class) from display inside the content.
Comment 1 Jon 2012-09-18 16:03:01 UTC
Sorry I'm a bit confused about this bug.
Are you saying the table with id toc should be stripped from the rendered html on mobile? If so why?

(Sorry I don't have much knowledge of the implications of the NOTOC keyword)
Comment 2 Derk-Jan Hartman 2012-09-18 16:54:25 UTC
The notoc keyword remove the table of contents from a page. In the beta (for which apparently the opt-in page changed again, so I can't check how it is now, but this was how it was before), would therefor not generate a ToC for a page. Instead it showed the template based Template:TOC001

In my opinion when using the beta website, the 'contents' table should always be visible, even if you have NOTOC.
Comment 3 Jon 2012-09-18 23:40:47 UTC
So I understand this now.
This page is using a hack to kill the default table of contents (TOC) and introduce its own TOC.

I am extremely against supporting this hack in mobile. What would make more sense is for this page to
* turn anchors into headings e.g. 28901–29000 should be wrapped in a h2 tag.
* NOTOC and custom table of contents should be removed - this is not maintainable

Table of contents should be improved in core to support the above if it doesn't for any reason. The existence of NOTOC in my opinion is a sign that we are failing our editors.

We should improve core to support these use cases. The last thing we want to do is introduce javascript in mobile to workaround these edge cases and introduce more code bloat.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links