Last modified: 2010-05-15 15:38:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T5765, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 3765 - wfAbruptExit in GlobalFunctions.php seems to make incorrect assumption about PHP's debug_backtrace() function
wfAbruptExit in GlobalFunctions.php seems to make incorrect assumption about ...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.5.x
PC Windows 2000
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-10-21 00:35 UTC by Nick Jenkins
Modified: 2010-05-15 15:38 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Allow wfAbruptExit to cope with unexpected debug_backtrace() output (563 bytes, patch)
2005-10-21 00:36 UTC, Nick Jenkins
Details

Description Nick Jenkins 2005-10-21 00:35:25 UTC
PHP's debug_backtrace() function can produce output that is not handled properly
by the wfAbruptExit function.

To illustrate, here is part of the output of doing a var_dump($bt) when running
with the latest PHP4.4 stable CVS snapshot:
=================================================
       }
      }
    }
  }
  [12]=>
  array(4) {
    ["function"]=>
    string(12) "out_revision"
    ["class"]=>
    string(12) "wikiimporter"
    ["type"]=>
    string(2) "->"
    ["args"]=>
    array(2) {
      [0]=>
      &resource(75) of type (xml)
      [1]=>
      &string(8) "revision"
    }
  }
  [13]=>
  array(4) {
    ["file"]=>
    string(62) "/var/www/hosts/local-wikipedia/wiki/includes/SpecialImport.php"
    ["line"]=>
    int(261)
    ["function"]=>
    string(9) "xml_parse"
    ["args"]=>
    array(3) {
      [0]=>
      &resource(75) of type (xml)
      [1]=>
===================================================

Note that $bt[12] does not contain a "file" or "line" key.

A 2-line patch will be attached shortly to add handling for this.
Comment 1 Nick Jenkins 2005-10-21 00:36:48 UTC
Created attachment 1011 [details]
Allow wfAbruptExit to cope with unexpected debug_backtrace() output
Comment 2 Brion Vibber 2005-10-28 09:40:23 UTC
Comitted to REL1_5 and HEAD.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links