Last modified: 2005-11-24 20:00:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 3758 - Special:Undelete page -> checkboxes not checked by default
Special:Undelete page -> checkboxes not checked by default
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
  Show dependency treegraph
Reported: 2005-10-20 11:30 UTC by dake
Modified: 2005-11-24 20:00 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description dake 2005-10-20 11:30:43 UTC
In Special:Undelete, one can select which contributions must be restored. In
Firefox (haven't tried with other browsers), the checkbox value is '1' but the
checkbox is NOT checked. HTML code reveals the problem : 

<input type="checkbox" name="ts20051020110735" value="1" />

Value="1" is not enough. It should be : 

<input type="checkbox" name="ts20051020110735" value="1" checked="1" />

to reflect the actual value. Quite easy to fix.

See :

checked [CI]
    When the type attribute has the value "radio" or "checkbox", this boolean
attribute specifies that the button is on. User agents must ignore this
attribute for other control types.
Comment 1 dake 2005-10-20 11:35:06 UTC
Fix is trivial in SpecialUndelete.php : 

Replace : 

$checkBox = "<input type=\"checkbox\" name=\"ts$ts\" value=\"1\" />";


$checkBox = "<input type=\"checkbox\" name=\"ts$ts\" value=\"1\" checked=\"1\" />";
Comment 2 Tietew 2005-10-20 12:03:21 UTC
If all checkboxes are not checked, all revisions are restored.

in XHTML, checked="1" is invalid; must be checked="checked".
Comment 3 dake 2005-10-20 18:07:56 UTC
>If all checkboxes are not checked, all revisions are restored.

yep, that's right but it's also counter-intuitive, I always thought I had to
check all of them to make a complete restoration. 
Comment 4 dake 2005-11-24 20:00:21 UTC
Why is this bug tagged as invalid ? 

Note You need to log in before you can comment on or make changes to this bug.