Last modified: 2012-05-31 18:23:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39194, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 37194 - remove *.deps.php files
remove *.deps.php files
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.20.x
All All
: Lowest minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: platformeng
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-05-29 12:00 UTC by Antoine "hashar" Musso (WMF)
Modified: 2012-05-31 18:23 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2012-05-29 12:00:35 UTC 
PHP had a nasty bug related to late/early binding and referenced at https://bugs.php.net/bug.php?id=56776 . The workaround was to add some .deps.php files to make sure code is loaded early.


$ find . -name '*deps.php'
./languages/classes/LanguageIu.deps.php
./languages/classes/LanguageKk.deps.php
./languages/classes/LanguageKu.deps.php
./languages/classes/LanguageShi.deps.php
./languages/classes/LanguageSr.deps.php
./languages/classes/LanguageZh.deps.php
./skins/Chick.deps.php
./skins/Modern.deps.php
./skins/MonoBook.deps.php
./skins/MySkin.deps.php
./skins/Simple.deps.php
./skins/Vector.deps.php


Since bug upstream php issue #56778 was fixed in PHP 5.1, I guess we can get ride of the deps files.
Comment 1 Antoine "hashar" Musso (WMF) 2012-05-29 12:06:59 UTC 
Proposed change: https://gerrit.wikimedia.org/r/9242
Comment 2 Antoine "hashar" Musso (WMF) 2012-05-31 18:23:22 UTC 
merged by Sam Reed. Will be in some 1.20wmf > 4 / MediaWiki 1.20
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links