Last modified: 2013-04-21 14:36:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 3677 - Disabling logo should not generate 404 requests
Disabling logo should not generate 404 requests
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.5.x
PC Windows 2000
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-10-11 06:05 UTC by Nick Jenkins
Modified: 2013-04-21 14:36 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Allow wgLogo to be disabled (1.22 KB, patch)
2005-10-11 06:06 UTC, Nick Jenkins
Details

Description Nick Jenkins 2005-10-11 06:05:26 UTC
Disabling the top-left logo should not generate requests for non-existent image
files.

Currently the Layout Customization instructions (ref:
http://meta.wikimedia.org/wiki/Layout_customization#How_do_I_customize_the_logo_in_the_top_left_corner.3F
) says "If you want to remove the logo completely, comment out the wgLogo variable."

However, if you do this, and then check the apache error logs, it shows entries
like so on every page view:
---------------------------------------------
ludo:~# tail -2 /var/log/apache/error.log
[Tue Oct 11 15:34:50 2005] [error] [client 192.168.0.2] File does not exist:
/var/www/hosts/wiki-homepage/wiki/upload/wiki.png
[Tue Oct 11 15:34:50 2005] [error] [client 192.168.0.2] File does not exist:
/var/www/hosts/wiki-homepage/broken.php3
ludo:~# 
---------------------------------------------
(The broken.php3 is because our local apache configuration displays this on 404
requests, but it's not been added to the wiki directory)

This image request happens because there is a fallback value specified for
wgLogo in includes/DefaultSettings.php on line 117: $wgLogo =
"{$wgUploadPath}/wiki.png";

A better approach may be to use the one outlined here:
http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/13574 
(i.e. a value of '-' for a variable means that it is disabled).

I'll attach a small patch shortly that allows $wgLogo to be set to "-" in
LocalSettings.php, and which really disables the top-left logo.
Comment 1 Nick Jenkins 2005-10-11 06:06:32 UTC
Created attachment 975 [details]
Allow wgLogo to be disabled
Comment 2 Nick Jenkins 2005-10-11 06:21:00 UTC
Just a related thought, but maybe the logo's path could be moved into the
MediaWiki: namespace (e.g. "MediaWiki:wgLogo"). That way it could be as easily
customized as other MediaWiki: variables, or set to "-" to disable it, all
without needing to edit any configuration files. Just an idea, but I don't have
a patch that does this.
Comment 3 Brion Vibber 2005-10-11 06:22:06 UTC
Instructions are wrong; there is no way to 'disable the logo', it's part of the skin.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links