Last modified: 2012-11-28 13:50:28 UTC
Return on textfield, this is a bit tricky as some likes it and some don't. I think it should be there as long as the user does not edit an text area. Its an assumption thing, people expect it to work like that from other pages. Tabbing seems to work as expected. Arraw keys does not leave the fields, perhaps they should. Its not obvious how short keys should work and I have not tested them. Title above site links is made as a mosaic of text fragments, thats not nice. I propose to change the total number and put it to the left of each row, it would make it possible to refer to rows by number and not only by content. Number of rows can be done as a style issue and then dropped for now because someone else can do it later. The number of new and unsaved rows should be marked visually, and not as part of the title. Adding stuff like that in the title string makes it harder to localize. Title string should come in three forms; no sitelinks, one sitelink, and many sitelinks. The number of items (if used) should be set in this string as a $N parameter. The toolbar to the right (in english) should align on one of the edges, probably the right one. This is although a styling issue and not very important as someonecan fix it later. Alignment of text fields vs ordinary text should be so the text itself doesn't move when it goes from edit-less to edit-ing mode. An alternative is to change the font so it is more clearly that the field goes into edit mode. This also is a styling issue.
Some errors due to missing user permissions should be reported somehow before they are actually errors. For example if the user lacks permission to edit the page as such should never go into edit mode, and if the user isn't allowed to edit individual elements they should not go into edit mode. It could still be some fine grained permissions and dependencies that can't be checked up front and will end in an error message.
The autocompletion of titles in the creation of sitelinks is not how I expect it to work, it only leaves the field as is. Could be nice to show the remaining of first entry from the list and then fill it in if the user tabs on.
