Last modified: 2011-12-23 19:53:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 3663 - ISSN Magic Numbers
ISSN Magic Numbers
Status: REOPENED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
unspecified
All All
: Low enhancement with 7 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-reviewed
Depends on: 10867
Blocks: 29473
  Show dependency treegraph
 
Reported: 2005-10-09 16:46 UTC by Forest
Modified: 2011-12-23 19:53 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
patches Parser.php for ISSN magicnumbering (1.73 KB, patch)
2005-10-09 16:48 UTC, Forest
Details
Periodical Special Page (2.45 KB, text/plain)
2005-10-09 16:49 UTC, Forest
Details
patch responds to criticism, integrated with current ISBN code (1.64 KB, patch)
2005-10-25 09:07 UTC, Forest
Details
fixed formatting in response to Brion's comment (1.61 KB, patch)
2005-12-05 13:35 UTC, Forest
Details
Patches Santitizer.php to catch ISSN links (336 bytes, patch)
2005-12-05 13:40 UTC, Forest
Details
patches SpecialPage.php (1.08 KB, patch)
2005-12-05 13:42 UTC, Forest
Details

Description Forest 2005-10-09 16:46:01 UTC
There was a request to add similar functionality for ISSN numbers as exists now for ISBN numbers. http://en.wikipedia.org/wiki/Wikipedia_talk:Book_sources

These files add this feature.
Comment 1 Forest 2005-10-09 16:48:46 UTC
Created attachment 961 [details]
patches Parser.php for ISSN magicnumbering
Comment 2 Forest 2005-10-09 16:49:55 UTC
Created attachment 962 [details]
Periodical Special Page
Comment 3 Ævar Arnfjörð Bjarmason 2005-10-09 18:13:22 UTC
(In reply to comment #1)
> Created an attachment (id=961) [edit]
> patches Parser.php for ISSN magicnumbering
> 

This patch is useless because the code that was supposed to use the function you
added is commented out, furthermore, making a new function to parse ISSN codes
rather than adding that functionality to the already existing ISBN function
(they're parsed almost in the same way),
Comment 4 Forest 2005-10-25 09:07:47 UTC
Created attachment 1018 [details]
patch responds to criticism, integrated with current ISBN code
Comment 5 Brion Vibber 2005-12-03 02:25:10 UTC
* Avoid mixing tabs and spaces; use tabs consistently
* Please follow existing code conventions on code block usage
* Will require patch to Sanitizer.php to protect against ISSN links in HTML 
bits
* Won't this not work without a patch to Booksources?
Comment 6 Forest 2005-12-05 13:35:52 UTC
Created attachment 1137 [details]
fixed formatting in response to Brion's comment
Comment 7 Forest 2005-12-05 13:40:51 UTC
Created attachment 1138 [details]
Patches Santitizer.php to catch ISSN links
Comment 8 Forest 2005-12-05 13:42:05 UTC
Created attachment 1139 [details]
patches SpecialPage.php
Comment 9 Forest 2005-12-05 13:48:46 UTC
*Responded to Brion's comments about format
*Included patch to Sanitizer.php
*Changed patch so that ISSN pages go to SpecialPeriodicalsources.php
*Added patch to SpecialPage.php to include SpecialPeriodicalsources.php
*attachment 962 [details] is SpecialPeriodicalsources.php

==Question==
What's the appropriate way to patch for messages
Comment 10 Omegatron 2006-12-05 15:44:52 UTC
What is this for?  ISBN is a label for a single book.  ISSN is a label for an
entire journal; not individual articles or even volumes.  What is going to be on
the "ISSN sources" page?  A single link to the web site of the journal?  What's
the point?
Comment 11 Chad H. 2009-03-13 13:11:57 UTC
WONTFIX'ing per comment 10 and lack of activity for 3 years.
Comment 12 Aryeh Gregor (not reading bugmail, please e-mail directly) 2009-03-13 13:14:13 UTC
Lack of activity is never a legitimate reason for WONTFIXing, but I don't think we want more magic like ISBN and RFC.  Better that those should be phased out in favor of templates at some point in the future.
Comment 13 Mark A. Hershberger 2010-12-02 19:00:37 UTC
re-opening to depend on Bug #26207
Comment 14 Chad H. 2011-12-23 19:53:58 UTC
Removing need-review keyword. This absolutely depends on 26207 which presumably would handle this cleanly without requiring Sanitizer & Parser changes.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links