Last modified: 2005-10-09 08:34:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T5660, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 3660 - windows/cygwin diff3 executable not detected.during install
windows/cygwin diff3 executable not detected.during install
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Installer (Other open bugs)
1.6.x
PC Windows Server 2003
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2005-10-09 06:28 UTC by Goodwill
Modified: 2005-10-09 08:34 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Installation Diff3 detection patch v0.1 (883 bytes, patch)
2005-10-09 06:30 UTC, Goodwill 		Details
Installation Diff3 detection patch v0.2 (878 bytes, patch)
2005-10-09 07:24 UTC, Goodwill 		Details
Installation Diff3 detection patch v0.3 (1.39 KB, patch)
2005-10-09 07:53 UTC, Goodwill 		Details
Installation Diff3 detection patch v0.4 (1.33 KB, patch)
2005-10-09 08:19 UTC, Goodwill 		Details
Show Obsolete (3) Add an attachment (proposed patch, testcase, etc.)

Description Goodwill 2005-10-09 06:28:56 UTC 
When running web installer on Windows the diff3.exe (usually the one that comes
with cygwin) executable is not located. Even when diff3.exe is located in the
windows path.

The detection mechanism search through some predefined path and the
environmental "PATH" variable. But since windows environmental PATH has a
different syntax and the windows executables have .exe extension, the current
search mechanism does not locate the windows version

I would like to submit a patch to fix it.for your consideration (only two small
changes within the current framework).
Comment 1 Goodwill 2005-10-09 06:30:07 UTC 
Created attachment 957 [details]
Installation Diff3 detection patch v0.1

Installation Diff3 detection patch v0.1
Comment 2 Goodwill 2005-10-09 07:24:59 UTC 
Created attachment 958 [details]
Installation Diff3 detection patch v0.2

Installation Diff3 detection patch v0.2.
A slightly better code using PATH_SEPARATOR and DIRECTORY_SEPARATOR constant
per brion's suggestion.
Comment 3 Goodwill 2005-10-09 07:53:18 UTC 
Created attachment 959 [details]
Installation Diff3 detection patch v0.3

Installation Diff3 detection patch v0.3
Per brion's suggestion:
Modified to have native path's (applies to back- and forward- slashes)
Comment 4 Goodwill 2005-10-09 08:19:00 UTC 
Created attachment 960 [details]
Installation Diff3 detection patch v0.4

Installation Diff3 detection patch v0.4
Yet again, per brion's suggestion:
make the code nicer *shakes fist*
Comment 5 Brion Vibber 2005-10-09 08:34:48 UTC 
Applied on HEAD.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links