Last modified: 2010-05-15 15:38:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 3642 - Premature instantiation of User object
Premature instantiation of User object
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User login and signup (Other open bugs)
1.5.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-10-07 14:54 UTC by Rob Church
Modified: 2010-05-15 15:38 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch for version 1.5 (634 bytes, patch)
2005-10-07 14:55 UTC, Rob Church
Details

Description Rob Church 2005-10-07 14:54:36 UTC
Line 74 of User.php in version 1.5 allocates a relatively heavy User object
before it is needed; during the period between allocation and use, several
possibilities for leaving the function are available.

Proposed to move the instantiation to just above it's use.
Comment 1 Rob Church 2005-10-07 14:55:32 UTC
Created attachment 947 [details]
Patch for version 1.5

Patch to fix the problem as I proposed above.
Comment 2 Brion Vibber 2005-10-09 07:24:41 UTC
Seems to have already been done on HEAD.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links