Last modified: 2011-03-09 21:14:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T5635, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 3635 - Premature instantiation of User object
Premature instantiation of User object
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User login and signup (Other open bugs)
1.5.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-10-06 23:28 UTC by Rob Church
Modified: 2011-03-09 21:14 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Rob Church 2005-10-06 23:28:49 UTC
(Tracking bug for the 1.5 manifestation of this problem)

User.php, line 53 allocates a new User object which is unused until line 74, and
which may be left created but unused if control returns from the method prior to
line 74; leaving a relatively heavy object lurking about.

Move line 53 to line 73, thus only instantiating the object before it is used.

(Was fixed in CVS HEAD but I didn't do a patch for 1.5 - will do this shortly)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links