Last modified: 2011-03-09 21:14:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 3635 - Premature instantiation of User object
Premature instantiation of User object
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User login and signup (Other open bugs)
1.5.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-10-06 23:28 UTC by Rob Church
Modified: 2011-03-09 21:14 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Rob Church 2005-10-06 23:28:49 UTC
(Tracking bug for the 1.5 manifestation of this problem)

User.php, line 53 allocates a new User object which is unused until line 74, and
which may be left created but unused if control returns from the method prior to
line 74; leaving a relatively heavy object lurking about.

Move line 53 to line 73, thus only instantiating the object before it is used.

(Was fixed in CVS HEAD but I didn't do a patch for 1.5 - will do this shortly)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links