Last modified: 2010-05-15 15:38:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 3619 - AuthPlugin::setPassword method argument list seems wrong
AuthPlugin::setPassword method argument list seems wrong
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User login and signup (Other open bugs)
1.5.x
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-10-05 21:01 UTC by Johannes Ernst
Modified: 2010-05-15 15:38 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Johannes Ernst 2005-10-05 21:01:40 UTC
AuthPlugin::setPassword is currently declared to use a single parameter,
$password. That makes no sense because an implementor of that method (e.g. in a
custom AuthPlugin) does not know whose user's password is supposed to be changed.

Also, the code in SpecialPreferences correctly invokes the method with two
parameters: $user and $password.

I suspect somebody got confused or copy-pasted from class User: there,
setPassword indeed only takes a single $password argument (because it is applied
to the User object which obviously knows what user it refers to).

While very easy to fix, I have taken the liberty to make this a major-severity
bug because it likely confuse countless AuthPlugin developers sooner or later.
Comment 1 Johannes Ernst 2005-10-06 17:37:04 UTC
still present in 1.5.0
Comment 2 Brion Vibber 2006-12-11 20:57:47 UTC
This was fixed in r17965

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links