Last modified: 2013-11-12 18:46:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38074, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 36074 - "Unterminated string constant" error in IE7 on action=edit
"Unterminated string constant" error in IE7 on action=edit
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
unspecified
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-18 19:20 UTC by Chris McMahon
Modified: 2013-11-12 18:46 UTC (History)
6 users (show)

See Also:
Web browser: Internet Explorer
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
screen shot (32.18 KB, image/png)
2012-04-18 19:20 UTC, Chris McMahon
Details
web console screen shot (66.79 KB, image/png)
2012-04-18 19:21 UTC, Chris McMahon
Details

Description Chris McMahon 2012-04-18 19:20:29 UTC
Created attachment 10431 [details]
screen shot

seen as a result of 1.20 on wikisource, NOT seen in 1.19 on enwiki: 

Follow a redlink to an edit page, e.g  https://en.wikisource.org/w/index.php?title=The_Silent_Short&action=edit&redlink=1

IE7 shows an error window "Unterminated string constant". see screen shot. 

Checking web console in Firefox upon loading a redlink edit page shows two errors present on wikisource (1.20) that are not present on enwiki (1.19).  see screen shot.

[12:58:21.194] Use of getAttributeNode() is deprecated. Use getAttribute() instead. @ https://en.wikisource.org/w/index.php?title=The_Silent_Short&action=edit&redlink=1

[12:58:21.225] Use of attributes' specified attribute is deprecated. It always returns true. @ https://en.wikisource.org/w/index.php?title=The_Silent_Short&action=edit&redlink=1
Comment 1 Chris McMahon 2012-04-18 19:21:17 UTC
Created attachment 10432 [details]
web console screen shot
Comment 2 JuneHyeon Bae (devunt) 2012-04-19 06:06:51 UTC
I can't see that error at Google Chrome 18.0.1025.162 for Linux (Ubuntu 10.04.4 LTS).
Comment 3 JuneHyeon Bae (devunt) 2012-04-19 09:16:53 UTC
'getAttributeNode()' and 'specified' problem is wikimedia bits's problem, not mediawiki.
https://bits.wikimedia.org/en.wikisource.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20120416T184457Z

And I can't testing first error since I don't have IE7.
Comment 4 Krinkle 2012-05-07 00:14:34 UTC
The warnings shown in Firefox are not related to MediaWiki and are not important problems. They are from jQuery internally and they will fix it upstream when needed.

The error "Unterminated string constant" shown in IE is not related to the Firefox warning but is a real bug. Rephrasing summary to emphasize that instead.

Note that from looking at the screenshot, it looks like this error is caused by a user script or site script from en.wikisource.org not something we can fix in the software.
Comment 5 Umherirrender 2013-11-12 18:46:51 UTC
There is bad syntax for IE in a local gadget, nothing for bugzilla -> INVALID

https://en.wikisource.org/wiki/MediaWiki:Gadget-Edittools.js contains a extra comma for a array definition.

Remove the comma in the following code snippet:

			$choise.show();
			$sections.not($choise).hide();
		},
 
		/**
		 * Convert the <a onclick> links to buttons in a given section.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links